From 4a464c75f05db84e07dfd6e3c3a54f72f002edc5 Mon Sep 17 00:00:00 2001 From: TheGeniusOfEternity Date: Tue, 14 Jan 2025 22:56:41 +0300 Subject: [PATCH 1/3] feat: New field in Note's schema Now you can send creatorId field from database to use it in frontend --- src/presentation/http/schema/Note.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/presentation/http/schema/Note.ts b/src/presentation/http/schema/Note.ts index 875f9421..3623d6c6 100644 --- a/src/presentation/http/schema/Note.ts +++ b/src/presentation/http/schema/Note.ts @@ -37,5 +37,8 @@ export const NoteSchema = { type: 'string', format: 'date-time', }, + creatorId: { + type: 'number', + }, }, }; From 9a05a16d43233ce20687a0d1292b287c28c35afb Mon Sep 17 00:00:00 2001 From: TheGeniusOfEternity Date: Wed, 29 Jan 2025 23:41:48 +0300 Subject: [PATCH 2/3] fix: added new field to tests Now we are waiting for creatorId field from notes api --- src/presentation/http/router/note.test.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/presentation/http/router/note.test.ts b/src/presentation/http/router/note.test.ts index 9f0a9a5b..e3e9c6e4 100644 --- a/src/presentation/http/router/note.test.ts +++ b/src/presentation/http/router/note.test.ts @@ -282,9 +282,10 @@ describe('Note API', () => { tools: [headerTool, paragraphTool], }); - /** Check if response has createdAt and updatedAt fields */ + /** Check if response has createdAt, updatedAt and creatorId fields */ expect(response?.json().note.createdAt).not.toBeNull(); expect(response?.json().note.updatedAt).not.toBeNull(); + expect(response?.json().note.creatorId).not.toBeNull(); } else { expect(response?.json()).toStrictEqual({ message: expectedMessage, From 9c14c3ce933dd232b3d7a5ab8c51fe22d7f61567 Mon Sep 17 00:00:00 2001 From: TheGeniusOfEternity Date: Tue, 4 Feb 2025 00:33:51 +0300 Subject: [PATCH 3/3] fix: note tests update Tiny fix in GET note/:notePublicId test --- src/presentation/http/router/note.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/presentation/http/router/note.test.ts b/src/presentation/http/router/note.test.ts index e3e9c6e4..4b5ad2b9 100644 --- a/src/presentation/http/router/note.test.ts +++ b/src/presentation/http/router/note.test.ts @@ -285,7 +285,7 @@ describe('Note API', () => { /** Check if response has createdAt, updatedAt and creatorId fields */ expect(response?.json().note.createdAt).not.toBeNull(); expect(response?.json().note.updatedAt).not.toBeNull(); - expect(response?.json().note.creatorId).not.toBeNull(); + expect(response?.json().note.creatorId).to.be.equal(creator.id); } else { expect(response?.json()).toStrictEqual({ message: expectedMessage,