Skip to content

Commit 1938dc1

Browse files
committed
fix requestId to rotate after 255 calls. colyseus/colyseus#242
1 parent f1fd74d commit 1938dc1

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

dist/colyseus.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "colyseus.js",
3-
"version": "0.10.5",
3+
"version": "0.10.6",
44
"description": "Multiplayer Game Client for the Browser",
55
"keywords": [
66
"colyseus",

src/Client.ts

+6-2
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ export class Client {
4545

4646
public getAvailableRooms(roomName: string, callback: (rooms: RoomAvailable[], err?: string) => void) {
4747
// reject this promise after 15 seconds.
48-
const requestId = ++this.requestId;
48+
const requestId = this.getNextRequestId();
4949
const removeRequest = () => delete this.roomsAvailableRequests[requestId];
5050
const rejectionTimeout = setTimeout(() => {
5151
removeRequest();
@@ -76,7 +76,7 @@ export class Client {
7676
reuseRoomInstance?: Room<T>,
7777
retryCount?: number,
7878
) {
79-
options.requestId = ++this.requestId;
79+
options.requestId = this.getNextRequestId();
8080

8181
const room = reuseRoomInstance || this.createRoom<T>(roomName, options);
8282

@@ -201,4 +201,8 @@ export class Client {
201201

202202
}
203203

204+
protected getNextRequestId() {
205+
return (++this.requestId % 255);
206+
}
207+
204208
}

0 commit comments

Comments
 (0)