Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor distribution upload code #20

Merged
merged 5 commits into from
Aug 6, 2018

Conversation

sodre
Copy link
Member

@sodre sodre commented Aug 4, 2018

This is a refactor of the upload routines so that the token is
rendered once for all uploads.

It uses list comprehensions to remove the nesting of the
previous for-loops and conditional statements.

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy
  • Ensured the license file is being packaged.

Close #14

@sodre
Copy link
Member Author

sodre commented Aug 4, 2018

@conda-forge-admin, please rerender.

@sodre sodre changed the title [WIP] Refactor distribution upload code Refactor distribution upload code Aug 4, 2018
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@sodre
Copy link
Member Author

sodre commented Aug 6, 2018

@conda-forge/core this is ready for review.

@scopatz
Copy link
Member

scopatz commented Aug 6, 2018

LGTM! I will merge tomorrow, if no one beats me to it.

@bgruening bgruening merged commit 53c72da into conda-forge:master Aug 6, 2018
@sodre sodre deleted the cleanup-refactor branch August 7, 2018 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sporadic cleanup issues on AppVeyor after upload
5 participants