-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate announcements page to news/
#2057
Conversation
history continues at conda-forge#767 Co-authored-by: Christian Roth <code@christianroth.dev>
conda-forge#878 Co-authored-by: Isuru Fernando <isuruf@gmail.com>
conda-forge#999 Co-authored-by: Matthew R. Becker <beckermr@users.noreply.github.com>
conda-forge#1008 Co-authored-by: Matthew R. Becker <beckermr@users.noreply.github.com> Co-authored-by: Isuru Fernando <isuruf@gmail.com>
conda-forge#1010 Co-authored-by: Matthew R. Becker <beckermr@users.noreply.github.com>
https://github.com/conda-forge/conda- forge.github.io/pull/1013 Co-authored-by: Matthew R. Becker <beckermr@users.noreply.github.com>
conda-forge#1058 Co-authored-by: Matthew R. Becker <beckermr@users.noreply.github.com>
conda-forge#1074 Co-authored-by: Matthew R. Becker <beckermr@users.noreply.github.com>
conda-forge#1094 Co-authored-by: Matthew R. Becker <beckermr@users.noreply.github.com>
conda-forge#1103 Co-authored-by: Uwe L. Korn <xhochy@users.noreply.github.com>
conda-forge#1105 Co-authored-by: Uwe L. Korn <xhochy@users.noreply.github.com> Co-authored-by: Filipe Fernandes <ocefpaf@gmail.com>
conda-forge#1106 Co-authored-by: Matthew R. Becker <beckermr@users.noreply.github.com>
conda-forge#1107 Co-authored-by: Filipe Fernandes <ocefpaf@gmail.com>
conda-forge#1114 Co-authored-by: Matthew R. Becker <beckermr@users.noreply.github.com>
conda-forge#1110 Co-authored-by: Uwe L. Korn <xhochy@users.noreply.github.com>
conda-forge#1112 Co-authored-by: Matthew R. Becker <beckermr@users.noreply.github.com>
conda-forge#1127 Co-authored-by: Matthew R. Becker <beckermr@users.noreply.github.com>
conda-forge#1129 Co-authored-by: Matthew R. Becker <beckermr@users.noreply.github.com>
conda-forge#1166 Co-authored-by: Matthew R. Becker <beckermr@users.noreply.github.com>
conda-forge#1203 Co-authored-by: Matthew R. Becker <beckermr@users.noreply.github.com>
conda-forge#1223 Co-authored-by: Matthew R. Becker <beckermr@users.noreply.github.com>
conda-forge#1446 Co-authored-by: Matthew R. Becker <beckermr@users.noreply.github.com>
conda-forge#1513 Co-authored-by: Isuru Fernando <isuruf@gmail.com>
conda-forge#1516 Co-authored-by: Isuru Fernando <isuruf@gmail.com>
conda-forge#1524 conda-forge#1595 conda-forge#1596 Co-authored-by: jakirkham <jakirkham@gmail.com> Co-authored-by: Isuru Fernando <isuruf@gmail.com>
conda-forge#1543 Co-authored-by: Wolf Vollprecht <w.vollprecht@gmail.com>
conda-forge#1555 Co-authored-by: Matthew R. Becker <beckermr@users.noreply.github.com>
conda-forge#1571 Co-authored-by: Matthew R. Becker <beckermr@users.noreply.github.com>
conda-forge#1609 Co-authored-by: Matthew R. Becker <beckermr@users.noreply.github.com>
@jaimergp do the links to single announcements still work? For example, links like this: https://conda-forge.org/docs/user/announcements.html#python-3-12-migration-and-python-3-11-by-default |
https://conda-forge.org/docs/user/announcements.html will redirect to https://conda-forge.org/news. No clue what happens with the anchors. Let me see if there's a way to hack something simple together. Edit: Ok, the
|
Well I'd really like each item to have its own link so that we can refer to specific items directly when communicating with folks. The current blog has links per post. Is there a reason that format would not work here? |
Yes, sorry, I misunderstood. Each announcement will have its own permalink of course. They are their own "post" with a URL. See the "single announcement" screenshot in #1971 (comment). What I didn't implement is a forwarder from |
Ahhhh. At least for the old announcements I think we want the links to forward. For future announcements we won't need that. |
A single static orphan page at the right location would be fine. |
Perfect! Thank you! |
The only other page that I think will need redirects is the getting in touch page. The rest of the docs can change without us worrying. |
@@ -63,4 +63,4 @@ Staying Up-to-date | |||
There are several sources that have the latest conda-forge information. | |||
|
|||
* `Blog <https://conda-forge.org/blog>`__: We blog about big feature enhancements and other items. Our blog has an Atom `feed <https://conda-forge.org/blog/atom.xml>`__. | |||
* `News <https://conda-forge.org/docs/user/announcements.html#announcements>`__: Our :ref:`announcements <news>` page has periodic notices about technical changes to our infrastructure. It is also served as an RSS `feed <https://conda-forge.org/docs/news.rss>`__. | |||
* `News <https://conda-forge.org/news>`__: Our news page has periodic notices about technical changes to our infrastructure. It is also served as an RSS `feed <https://conda-forge.org/news/rss.xml>`__. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@beckermr, if you meant these links, they have been updated too so they point to the new URLs 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I mean this link https://conda-forge.org/docs/orga/getting-in-touch.html#getting-in-touch when it gets moved over in future PRs. I should have put my comment in the main issue.
I will merge this afternoon if no more comments come in. |
Thanks Jaime! 🙏 Will take a closer look in a moment At first pass a few things stick out to me, this change could make the commit history harder to navigate. We may want to ignore this commit Also this creates a lot of files as each announcement is broken out. Maybe that is ok as we do the agenda this way and it could make it easier to add a new item. Though it could complicate finding an item. We might also want to lint names to ensure they match whatever format we expect Was there a preview link somewhere? Looked through the PR, but maybe I missed it |
The multiple files is way better IMHO. |
Any thoughts on this question? Will need this to finish reviewing |
We have no preview links in GH Pages. We could set a Netlify account for conda-forge just for the previews but I haven't bothered yet. I could also commit this to cf-infra-docs. For now, you can render locally though:
Typed that on my phone so some paths might be wrong but you get the idea :) |
Alternatively, you can extract this tarball and preview it with |
The filename is not super strict. Docusaurus supports several schemes, and it can be overridden in the frontmatter. |
I agree. We don't need a specific lint for this. |
@jakirkham, is this ok to go or do you still want to add some feedback? Thanks! 🙏 |
I'm sorry Jaime. Got clobbered with work tasks this week. Will pick this up Monday next week |
Sorry to ping again @jakirkham. I understand you might be busy with other higher prio tasks, but if that's ok, I'd like to move forward with this and we can revisit your feedback once it goes live. We made extra sure no links are broken so I think there's no risk in just going with it. We can adjust things later if needed. Wdyt? |
LGTM for going ahead! |
I'm so sorry Jaime 😞 Please go ahead without me. Maybe I can look at what is produce on the webpage and we can discuss after |
PR Checklist:
See #1971 (comment).
I split the
announcements.rst
page in individual pages and put them all together undernews/
. I've left a reference to the originating PRs where relevant, along with the coauthorship, in each commit. I've chosen to list 10 announcements per page, although we can technically render all of them if we wish (by setting theperPagePosts
value toALL
).The RSS feed is now generated by Docusaurus so I removed our custom machinery. There's only one gotcha and it's that the redirect plugin doesn't cover static assets like the RSS XML, so we just copy it in place in the build script so the old link still works.
Script used to split the single announcements.rst into multiple markdowns