Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add blog post about v1 recipe format #2450

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

wolfv
Copy link
Member

@wolfv wolfv commented Feb 14, 2025

PR Checklist:

  • note any issues closed by this PR with closing keywords
  • if you are adding a new page under docs/ or community/, you have added it to the sidebar in the corresponding _sidebar.json file
  • put any other relevant information below

@wolfv wolfv requested a review from a team as a code owner February 14, 2025 08:53
Copy link

netlify bot commented Feb 14, 2025

Deploy Preview for conda-forge-previews ready!

Name Link
🔨 Latest commit e81ebce
🔍 Latest deploy log https://app.netlify.com/sites/conda-forge-previews/deploys/67b0e00e3c23200008046dbc
😎 Deploy Preview https://deploy-preview-2450--conda-forge-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 60
Accessibility: 96
Best Practices: 100
SEO: 89
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@jaimergp jaimergp Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go in blog/ more than news/.

Copy link
Member

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One major comment is about how we phrase items around the format versus the tools that implement it. Basically, we should describe the format as improving on the old v0 format. Then at the end, we say that conda-forge supports the v1 format using rattler-build as the current default v1 build tool.

Comment on lines 10 to 12
- The new recipe executes much faster, which is partially due to some design decisions (no more recursive evaluation) as well as due to rattler-build building on top of a modern re-implementation of the conda standards in Rust.
- The log output of rattler-build is greatly improved, always showing the user what the final files in the package are and the final metadata.
- Some features of conda-build, such as multiple outputs, had a lot of implicit behavior. We are fixing that in the v1 recipe.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These three bullet points need to separate out two distinct things, namely the format versus the tools that use the format.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure ... this blog post is about the integration in conda-forge and that relies on rattler-build a lot. This is not only about the v0 vs v1 format ...

wolfv and others added 8 commits February 15, 2025 19:34
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
@wolfv
Copy link
Member Author

wolfv commented Feb 15, 2025

One major comment is about how we phrase items around the format versus the tools that implement it. Basically, we should describe the format as improving on the old v0 format. Then at the end, we say that conda-forge supports the v1 format using rattler-build as the current default v1 build tool.

I don't mind this in particular, but I do think that the integration into conda-forge is very much related to rattler-build as well. And this blog post is mainly about the integration into conda-forge, not the recipe format.

Also not sure what we want to achieve by detaching these things more?

@beckermr
Copy link
Member

The two are not synonymous and that distinction should be made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants