Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CRM 0.4.1 passes some tests now #2223

Merged
merged 4 commits into from
Jan 19, 2025
Merged

fix: CRM 0.4.1 passes some tests now #2223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4f76ee1
fix: CRM 0.4.1 passes some tests now
beckermr Jan 17, 2025
543ca6f
fix: this test passes now
beckermr Jan 17, 2025
bfefe7b
doc: add news
beckermr Jan 17, 2025
99d384d
fix: syntax in test req
beckermr Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
python=3.11
coverage
coveralls
conda-recipe-manager
conda-recipe-manager>=0.4.1
conda-souschef
conda-forge-tick

Expand Down
23 changes: 23 additions & 0 deletions news/crm.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
**Added:**

* <news item>

**Changed:**

* <news item>

**Deprecated:**

* <news item>

**Removed:**

* <news item>

**Fixed:**

* Fixed error in testing where tests fail for ``conda-recipe-manager >=0.4.1``. (#2223)

**Security:**

* <news item>
3 changes: 1 addition & 2 deletions tests/test_lint_recipe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3956,7 +3956,6 @@ def test_lint_recipe_parses_forblock():

def test_lint_recipe_parses_spacing():
with tempfile.TemporaryDirectory() as tmpdir:
# CRM fails if the yaml has differing spacing
with open(os.path.join(tmpdir, "meta.yaml"), "w") as f:
f.write(
textwrap.dedent(
Expand Down Expand Up @@ -3993,7 +3992,7 @@ def test_lint_recipe_parses_spacing():
)
for hint in hints
), hints
assert any(
assert not any(
hint.startswith(
"The recipe is not parsable by parser `conda-recipe-manager"
)
Expand Down
Loading