Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use latest conda-build again #20

Merged
merged 4 commits into from
May 30, 2024
Merged

Use latest conda-build again #20

merged 4 commits into from
May 30, 2024

Conversation

conda-forge-admin
Copy link
Contributor

@conda-forge-admin conda-forge-admin commented May 30, 2024 •
edited by jakirkham
Loading

Previously we saw a bug with conda-build version 24.5.0 ( #16 (comment) ) ( conda/conda-build#5342 ); so, had pinned conda-build to 24.3.0 ( #17 ), which didn't have this issue

Recently a fix was made upstream in conda-build ( conda/conda-build#5345 ), which should fix what we were seeing. This fix was included in conda-build version 24.5.1

So try relaxing the conda-build constraint to allow a newer conda-build to see if this fixes the issue. If so, we can go back to using latest conda-build

Fixes #18
Closes #16

@conda-forge-admin conda-forge-admin requested a review from a team as a code owner May 30, 2024 02:35
@conda-forge-webservices conda-forge-webservices bot mentioned this pull request May 30, 2024
Closed
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham jakirkham marked this pull request as draft May 30, 2024 02:36
@github-actions GitHub Actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest webservices GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or you can try rerendeing locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/cuda-nvtx-feedstock/actions/runs/9296108605.

@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

conda-forge-webservices[bot] and others added 2 commits May 30, 2024 02:40
MNT: Re-rendered with conda-build 24.5.1, conda-smithy 3.36.1, and co…
839f2e2 
…nda-forge-pinning 2024.05.29.16.17.59
@jakirkham
Revert "Use conda-build version 24.3"
6e470e1 
This reverts commit 4a95c10.

Allows using the latest `conda-build` again. Currently `conda-build`
version `24.5.1`, which fixes the bug that we saw before.
@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

@jakirkham jakirkham changed the title MNT: rerender Use latest conda-build again May 30, 2024
@jakirkham jakirkham marked this pull request as ready for review May 30, 2024 02:55
@jakirkham
Copy link
Member

Looking good. Will queue this to merge when CI passes

@jakirkham jakirkham added the automerge Merge the PR when CI passes label May 30, 2024
@github-actions github-actions bot merged commit 788a2a2 into conda-forge:main May 30, 2024
5 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
automerge Merge the PR when CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Relax conda-build pinning
2 participants
@conda-forge-admin @jakirkham