Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 5.46 #8

Merged
merged 11 commits into from
Dec 11, 2024
Merged

Update 5.46 #8

merged 11 commits into from
Dec 11, 2024

Conversation

blmaier
Copy link
Contributor

@blmaier blmaier commented Dec 3, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Dec 3, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12263897839. Examine the logs at this URL for more detail.

@@ -77,7 +85,7 @@ outputs:
about:
home: http://darwinsys.com/file
summary: Fine Free File Command
license: BSD-2-Clause
license: BSD-2-Clause-Darwin
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this is the correct SPDX license identifier. It's a identifier specifically for file.
https://spdx.org/licenses/BSD-2-Clause-Darwin.html

The linter warns about it as it appears to be more recently added to SPDX. I opened a PR to smithy to update the SPDX license list.
conda-forge/conda-smithy#2177

The tests under the `file` subpackage are not running.

The conda forge docs recommend the top-level package's name should be
different from the subpackage's names. Changing the top-level fixes the
tests so they start running.

https://conda-forge.org/docs/maintainer/knowledge_base/#common-pitfalls-with-outputs
@blmaier
Copy link
Contributor Author

blmaier commented Dec 6, 2024

@chrisburr @mariusvniekerk @mrakitin could I get a review on this?

@blmaier
Copy link
Contributor Author

blmaier commented Dec 10, 2024

Hi @conda-forge/core, this repo appears to be abandoned, could you look at it?

Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviving this feedstock!

@blmaier blmaier requested a review from h-vetinari December 10, 2024 20:31
@h-vetinari h-vetinari merged commit 20d5ff3 into conda-forge:main Dec 11, 2024
7 checks passed
@blmaier blmaier deleted the update-5.46 branch December 14, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants