-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 5.46 #8
Update 5.46 #8
Conversation
…onda-forge-pinning 2024.12.03.09.04.35
…onda-forge-pinning 2024.12.03.09.04.35
…onda-forge-pinning 2024.12.03.09.04.35
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
Documentation on acceptable licenses can be found here. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12263897839. Examine the logs at this URL for more detail. |
@@ -77,7 +85,7 @@ outputs: | |||
about: | |||
home: http://darwinsys.com/file | |||
summary: Fine Free File Command | |||
license: BSD-2-Clause | |||
license: BSD-2-Clause-Darwin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note this is the correct SPDX license identifier. It's a identifier specifically for file
.
https://spdx.org/licenses/BSD-2-Clause-Darwin.html
The linter warns about it as it appears to be more recently added to SPDX. I opened a PR to smithy to update the SPDX license list.
conda-forge/conda-smithy#2177
The tests under the `file` subpackage are not running. The conda forge docs recommend the top-level package's name should be different from the subpackage's names. Changing the top-level fixes the tests so they start running. https://conda-forge.org/docs/maintainer/knowledge_base/#common-pitfalls-with-outputs
…onda-forge-pinning 2024.12.03.09.04.35
@chrisburr @mariusvniekerk @mrakitin could I get a review on this? |
Hi @conda-forge/core, this repo appears to be abandoned, could you look at it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reviving this feedstock!
…onda-forge-pinning 2024.12.10.18.05.37
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)