Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix lack of py files in linux #82

Merged
merged 4 commits into from
Dec 23, 2023
Merged

Conversation

hmaarrfk
Copy link
Contributor

Closes #79
Closes #80
Closes #81
Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hmaarrfk
Copy link
Contributor Author

@conda-forge-admin please rerender

@erykoff
Copy link

erykoff commented Dec 22, 2023

Still failing...

@hmaarrfk
Copy link
Contributor Author

Still failing...

I'm not sure what this is supposed to mean.

I know it is failing. for some reason i managed to get it working once locally with what I thought was due to --no-build-isolation but I guess i was wrong.

I marked as draft to communicate that it isn't perfect.

I'm skipping the large build matrix to save CIs while I troubleshoot.

@erykoff
Copy link

erykoff commented Dec 22, 2023

Yeah, I thought the --no-build-isolation was the thing as well, and then I checked back and noticed that it didn't work. I see you're trying the old version to see if it's something with pydantic or something with one of the build tools that changed. Not fun!

@hmaarrfk
Copy link
Contributor Author

The crazy thing, i've reverted all these packages:
image

Maybe i have to revert rust too???
image

@erykoff
Copy link

erykoff commented Dec 23, 2023

Did this ever work? Is the problem that pydantic feedstock needs no build isolation and that’s installing these extra files? (Just speculating based on crazy evidence so far)

@hmaarrfk
Copy link
Contributor Author

See current theory

#81 (comment)

@hmaarrfk hmaarrfk changed the title No build isolation fix lack of py files in linux Dec 23, 2023
@hmaarrfk hmaarrfk marked this pull request as ready for review December 23, 2023 03:14
@xhochy
Copy link
Member

xhochy commented Dec 23, 2023

I didn't see an option in maturin to ignore the gitignore, so we need to live with this workaround for now :(

@xhochy xhochy merged commit aabf5da into conda-forge:main Dec 23, 2023
36 checks passed
@xhochy
Copy link
Member

xhochy commented Dec 23, 2023

This means that all maturin based projects are currently broken 😱

@xhochy
Copy link
Member

xhochy commented Dec 23, 2023

Posted conda-forge/conda-smithy#1818 as a workaround

@davidhewitt
Copy link

Thanks @hmaarrfk @xhochy 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pydantic-core 2.14.6 unusable on Linux 64
4 participants