Rebuild for CUDA 12 w/arch support #25

regro-cf-autotick-bot · 2023-11-14T15:18:24Z

This PR has been triggered in an effort to update cuda120.

Notes and instructions for merging this PR:

Please merge the PR only after the tests have passed.
Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

Here are some more details about this specific migrator:

The transition to CUDA 12 SDK includes new packages for all CUDA libraries and build tools. Notably, the cudatoolkit package no longer exists, and packages should depend directly on the specific CUDA libraries (libcublas, libcusolver, etc) as needed. For an in-depth overview of the changes and to report problems see this issue. Please feel free to raise any issues encountered there. Thank you! 🙏

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

_{This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/6865184761, please use this URL for debugging.}

The transition to CUDA 12 SDK includes new packages for all CUDA libraries and build tools. Notably, the cudatoolkit package no longer exists, and packages should depend directly on the specific CUDA libraries (libcublas, libcusolver, etc) as needed. For an in-depth overview of the changes and to report problems [see this issue]( conda-forge/conda-forge.github.io#1963 ). Please feel free to raise any issues encountered there. Thank you! 🙏

…nda-forge-pinning 2023.11.14.13.24.40

conda-forge-webservices · 2023-11-14T15:18:31Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

…nda-forge-pinning 2023.11.14.16.04.48

github-actions · 2023-11-14T16:12:30Z

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

linter: passed
azure: failed

Thus the PR was not passing and not merged.

jakirkham · 2023-11-17T03:16:00Z

Think we need to add CUDA 12.0 to this list

torch-scatter-feedstock/recipe/build.sh

Lines 4 to 20 in eaaac38

    
           export TORCH_CUDA_ARCH_LIST="3.5;5.0+PTX" 
        
           if [[ ${cuda_compiler_version} == 9.0* ]]; then 
        
               export TORCH_CUDA_ARCH_LIST="$TORCH_CUDA_ARCH_LIST;6.0;7.0" 
        
           elif [[ ${cuda_compiler_version} == 9.2* ]]; then 
        
               export TORCH_CUDA_ARCH_LIST="$TORCH_CUDA_ARCH_LIST;6.0;6.1;7.0" 
        
           elif [[ ${cuda_compiler_version} == 10.* ]]; then 
        
               export TORCH_CUDA_ARCH_LIST="$TORCH_CUDA_ARCH_LIST;6.0;6.1;7.0;7.5" 
        
           elif [[ ${cuda_compiler_version} == 11.0* ]]; then 
        
               export TORCH_CUDA_ARCH_LIST="$TORCH_CUDA_ARCH_LIST;6.0;6.1;7.0;7.5;8.0" 
        
           elif [[ ${cuda_compiler_version} == 11.1* ]]; then 
        
               export TORCH_CUDA_ARCH_LIST="$TORCH_CUDA_ARCH_LIST;6.0;6.1;7.0;7.5;8.0;8.6" 
        
           elif [[ ${cuda_compiler_version} == 11.2* ]]; then 
        
               export TORCH_CUDA_ARCH_LIST="$TORCH_CUDA_ARCH_LIST;6.0;6.1;7.0;7.5;8.0;8.6" 
        
           else 
        
               echo "unsupported cuda version. edit build.sh" 
        
               exit 1 
        
           fi

Maybe this list helps?

github-actions · 2023-11-17T15:20:32Z

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

sarthakpati · 2023-11-17T15:20:37Z

Think we need to add CUDA 12.0 to this list

torch-scatter-feedstock/recipe/build.sh

Lines 4 to 20 in eaaac38

export TORCH_CUDA_ARCH_LIST="3.5;5.0+PTX"

if [[ ${cuda_compiler_version} == 9.0* ]]; then

export TORCH_CUDA_ARCH_LIST="$TORCH_CUDA_ARCH_LIST;6.0;7.0"

elif [[ ${cuda_compiler_version} == 9.2* ]]; then

export TORCH_CUDA_ARCH_LIST="$TORCH_CUDA_ARCH_LIST;6.0;6.1;7.0"

elif [[ ${cuda_compiler_version} == 10.* ]]; then

export TORCH_CUDA_ARCH_LIST="$TORCH_CUDA_ARCH_LIST;6.0;6.1;7.0;7.5"

elif [[ ${cuda_compiler_version} == 11.0* ]]; then

export TORCH_CUDA_ARCH_LIST="$TORCH_CUDA_ARCH_LIST;6.0;6.1;7.0;7.5;8.0"

elif [[ ${cuda_compiler_version} == 11.1* ]]; then

export TORCH_CUDA_ARCH_LIST="$TORCH_CUDA_ARCH_LIST;6.0;6.1;7.0;7.5;8.0;8.6"

elif [[ ${cuda_compiler_version} == 11.2* ]]; then

export TORCH_CUDA_ARCH_LIST="$TORCH_CUDA_ARCH_LIST;6.0;6.1;7.0;7.5;8.0;8.6"

else

echo "unsupported cuda version. edit build.sh"

exit 1

fi

Maybe this list helps?

Thanks! I have updated the recipe - can you have a pass?

jakirkham

Thanks @sarthakpati ! 🙏

Sorry for the delay

Made a few suggestions below on similar logic found in PyTorch, which may be a better fit for our needs here

Hope that helps! Please let me know if you have any questions 🙂

jakirkham · 2023-11-17T20:22:54Z

recipe/build.sh

@@ -2,6 +2,9 @@ if [[ "$cuda_compiler_version" == "None" ]]; then
  export FORCE_CUDA=0
 else
  export TORCH_CUDA_ARCH_LIST="3.5;5.0+PTX"
+  # Duplicate lists because of https://bitbucket.org/icl/magma/pull-requests/32


Think we can drop this comment (since this is specific to MAGMA)

recipe/build.sh

jakirkham · 2023-11-28T05:23:36Z

recipe/build.sh

@@ -12,8 +15,16 @@ else
      export TORCH_CUDA_ARCH_LIST="$TORCH_CUDA_ARCH_LIST;6.0;6.1;7.0;7.5;8.0"
  elif [[ ${cuda_compiler_version} == 11.1* ]]; then
      export TORCH_CUDA_ARCH_LIST="$TORCH_CUDA_ARCH_LIST;6.0;6.1;7.0;7.5;8.0;8.6"


Can drop anything before CUDA 11.2+ as conda-forge only builds for CUDA 11.2+ ( conda-forge/conda-forge-pinning-feedstock#1708 ). Should help keep this more manageable

recipe/build.sh

jakirkham · 2023-11-28T05:34:51Z

.ci_support/migrations/cuda120.yaml

+      - 11.2                       # [(linux or win) and os.environ.get("CF_CUDA_ENABLED", "False") == "True"]
+      - 12.0                       # [(linux or win) and os.environ.get("CF_CUDA_ENABLED", "False") == "True"]
+  commit_message: |
+    Rebuild for CUDA 12 w/arch support


Let's grab the latest migrator file from conda-forge-pinning. Not expecting a huge difference. Still handy if we add Windows later

Co-authored-by: jakirkham <jakirkham@gmail.com>

recipe/build.sh

jakirkham · 2023-11-28T20:26:46Z

Thanks Sarthak! 🙏

Would also suggest dropping any CUDA versions before 11.2 ( as CUDA 11.2 is the minimum CUDA version in conda-forge conda-forge/conda-forge-pinning-feedstock#1708 )

IOW think we can delete these lines

sarthakpati · 2023-11-28T20:35:56Z

Thanks Sarthak! 🙏

Would also suggest dropping any CUDA versions before 11.2 ( as CUDA 11.2 is the minimum CUDA version in conda-forge conda-forge/conda-forge-pinning-feedstock#1708 )

IOW think we can delete these lines

Done! Is this okay, now?

jakirkham

Thanks Sarthak! 🙏

Had a couple minor suggestions below

Generally this is looking pretty good

recipe/build.sh

Co-authored-by: jakirkham <jakirkham@gmail.com>

sarthakpati · 2023-11-28T22:57:41Z

Thanks Sarthak! 🙏

Had a couple minor suggestions below

Generally this is looking pretty good

Thank you for your help with this!

…nda-forge-pinning 2024.03.07.20.43.08

…-autotick-bot/rebuild-cuda120-0-2_h857b6b

jakirkham · 2024-03-13T00:14:27Z

@conda-forge-admin , please re-render

…nda-forge-pinning 2024.03.12.21.52.52

sarthakpati · 2024-03-13T13:52:23Z

@conda-forge-admin , please re-render

github-actions · 2024-03-13T13:55:40Z

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/torch-scatter-feedstock/actions/runs/8265821247.

jakirkham

Thanks Sarthak! 🙏

Added some suggestions below to fix CI issues that cropped up

.ci_support/migrations/cuda120.yaml

recipe/meta.yaml

Co-authored-by: jakirkham <jakirkham@gmail.com>

sarthakpati · 2024-03-14T13:15:07Z

Thank you so much for your help @jakirkham!!! 🙏🏽

jakirkham

Thanks Sarthak! 🙏

Looks like Python 3.8 is still failing. Would suggest we just skip Python 3.8 on Linux CUDA builds for now

Made some suggestions below

recipe/meta.yaml

Co-authored-by: jakirkham <jakirkham@gmail.com>

jakirkham · 2024-03-19T17:40:13Z

@conda-forge-admin , please re-render

…nda-forge-pinning 2024.03.19.15.37.47

sarthakpati

LGTM!

Thank you so much for your help @jakirkham!

Would you like to be a maintainer for this package? 😄

jakirkham · 2024-03-20T19:44:00Z

Congratulations Sarthak! 🎉

Glad we were able to get this one in 😄

As to maintainership, I'm probably on too many things already. So unfortunately will need to pass. Though am still happy to answer questions and make suggestions. Hope that is ok

sarthakpati · 2024-03-22T13:28:27Z

Of course, thank you so much for all your help!

regro-cf-autotick-bot added 2 commits November 14, 2023 15:17

MNT: Re-rendered with conda-build 3.27.0, conda-smithy 3.29.0, and co…

d19869c

…nda-forge-pinning 2023.11.14.13.24.40

regro-cf-autotick-bot requested a review from sarthakpati as a code owner November 14, 2023 15:18

sarthakpati added the automerge Merge the PR when CI passes label Nov 14, 2023

regro-cf-autotick-bot added 2 commits November 14, 2023 16:09

Rebuild for CUDA 11.8 w/arch support

8ee3691

MNT: Re-rendered with conda-build 3.27.0, conda-smithy 3.29.0, and co…

dfdceff

…nda-forge-pinning 2023.11.14.16.04.48

added new logic for cuda 11.8 and 12

8e06e3e

github-actions bot removed the automerge Merge the PR when CI passes label Nov 17, 2023

jakirkham reviewed Nov 28, 2023

View reviewed changes

sarthakpati and others added 7 commits November 28, 2023 15:13

Update recipe/build.sh

cae35c2

Co-authored-by: jakirkham <jakirkham@gmail.com>

Update recipe/build.sh

d3b2245

Co-authored-by: jakirkham <jakirkham@gmail.com>

Update recipe/build.sh

3f03163

Co-authored-by: jakirkham <jakirkham@gmail.com>

Update recipe/build.sh

80c24bb

Co-authored-by: jakirkham <jakirkham@gmail.com>

Update recipe/build.sh

d7b69d5

Co-authored-by: jakirkham <jakirkham@gmail.com>

Update recipe/build.sh

da4b082

Co-authored-by: jakirkham <jakirkham@gmail.com>

Update recipe/build.sh

f0c0a73

Co-authored-by: jakirkham <jakirkham@gmail.com>

sarthakpati reviewed Nov 28, 2023

View reviewed changes

recipe/build.sh Outdated Show resolved Hide resolved

Update recipe/build.sh

42bf188

removed older cuda

d62e7be

jakirkham reviewed Nov 28, 2023

View reviewed changes

recipe/build.sh Outdated Show resolved Hide resolved

recipe/build.sh Outdated Show resolved Hide resolved

sarthakpati and others added 2 commits November 28, 2023 16:57

Update recipe/build.sh

72e2a0c

Co-authored-by: jakirkham <jakirkham@gmail.com>

Update recipe/build.sh

c36f1bc

Co-authored-by: jakirkham <jakirkham@gmail.com>

conda-forge-webservices[bot] and others added 5 commits March 7, 2024 21:22

MNT: Re-rendered with conda-build 24.1.2, conda-smithy 3.31.1, and co…

30650ea

…nda-forge-pinning 2024.03.07.20.43.08

MNT: Re-rendered with conda-build 24.1.2, conda-smithy 3.31.1, and co…

39650f9

…nda-forge-pinning 2024.03.07.20.43.08

Merge regro-cf-autotick-bot/rebuild-cuda118-0-1_hc7cb54 into regro-cf…

81ec276

…-autotick-bot/rebuild-cuda120-0-2_h857b6b

Sort conda-forge.yml keys

7a4964e

Free space on Azure

4769a0f

conda-forge-webservices[bot] and others added 2 commits March 13, 2024 00:17

MNT: Re-rendered with conda-build 24.1.2, conda-smithy 3.31.1, and co…

5eac8c7

…nda-forge-pinning 2024.03.12.21.52.52

added suggestions from @jakirkham

620a64c

jakirkham reviewed Mar 13, 2024

View reviewed changes

jakirkham mentioned this pull request Mar 13, 2024

[3.8] Build against libxcrypt on Linux conda-forge/python-feedstock#668

Merged

5 tasks

sarthakpati and others added 6 commits March 14, 2024 09:13

Update .ci_support/migrations/cuda120.yaml

80b8df7

Co-authored-by: jakirkham <jakirkham@gmail.com>

Update .ci_support/migrations/cuda120.yaml

ec4b8fd

Co-authored-by: jakirkham <jakirkham@gmail.com>

Update .ci_support/migrations/cuda120.yaml

ec435e3

Co-authored-by: jakirkham <jakirkham@gmail.com>

Update .ci_support/migrations/cuda120.yaml

bb76b80

Co-authored-by: jakirkham <jakirkham@gmail.com>

Update recipe/meta.yaml

9826252

Co-authored-by: jakirkham <jakirkham@gmail.com>

Update recipe/meta.yaml

f3f8e5d

Co-authored-by: jakirkham <jakirkham@gmail.com>

jakirkham reviewed Mar 18, 2024

View reviewed changes

recipe/meta.yaml Outdated Show resolved Hide resolved

recipe/meta.yaml Outdated Show resolved Hide resolved

sarthakpati and others added 2 commits March 19, 2024 08:51

Update recipe/meta.yaml

1609305

Co-authored-by: jakirkham <jakirkham@gmail.com>

Update recipe/meta.yaml

9bf4435

Co-authored-by: jakirkham <jakirkham@gmail.com>

MNT: Re-rendered with conda-build 24.1.2, conda-smithy 3.32.0, and co…

bdaf8e9

…nda-forge-pinning 2024.03.19.15.37.47

sarthakpati approved these changes Mar 20, 2024

View reviewed changes

sarthakpati merged commit 2f8b5c3 into conda-forge:main Mar 20, 2024
27 checks passed

regro-cf-autotick-bot deleted the rebuild-cuda120-0-2_h857b6b branch March 20, 2024 12:49

jakirkham mentioned this pull request Mar 20, 2024

Rebuild for CUDA 12 w/arch + Windows support #28

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rebuild for CUDA 12 w/arch support #25

Rebuild for CUDA 12 w/arch support #25

regro-cf-autotick-bot commented Nov 14, 2023

conda-forge-webservices bot commented Nov 14, 2023

github-actions bot commented Nov 14, 2023

jakirkham commented Nov 17, 2023

github-actions bot commented Nov 17, 2023

sarthakpati commented Nov 17, 2023

jakirkham left a comment

jakirkham Nov 17, 2023

jakirkham Nov 28, 2023

jakirkham Nov 28, 2023

jakirkham commented Nov 28, 2023

sarthakpati commented Nov 28, 2023

jakirkham left a comment

sarthakpati commented Nov 28, 2023

jakirkham commented Mar 13, 2024

sarthakpati commented Mar 13, 2024

github-actions bot commented Mar 13, 2024

jakirkham left a comment

sarthakpati commented Mar 14, 2024

jakirkham left a comment

jakirkham commented Mar 19, 2024

sarthakpati left a comment •

edited

Loading

jakirkham commented Mar 20, 2024

sarthakpati commented Mar 22, 2024

Rebuild for CUDA 12 w/arch support #25

Rebuild for CUDA 12 w/arch support #25

Conversation

regro-cf-autotick-bot commented Nov 14, 2023

conda-forge-webservices bot commented Nov 14, 2023

github-actions bot commented Nov 14, 2023

jakirkham commented Nov 17, 2023

github-actions bot commented Nov 17, 2023

sarthakpati commented Nov 17, 2023

jakirkham left a comment

Choose a reason for hiding this comment

jakirkham Nov 17, 2023

Choose a reason for hiding this comment

jakirkham Nov 28, 2023

Choose a reason for hiding this comment

jakirkham Nov 28, 2023

Choose a reason for hiding this comment

jakirkham commented Nov 28, 2023

sarthakpati commented Nov 28, 2023

jakirkham left a comment

Choose a reason for hiding this comment

sarthakpati commented Nov 28, 2023

jakirkham commented Mar 13, 2024

sarthakpati commented Mar 13, 2024

github-actions bot commented Mar 13, 2024

jakirkham left a comment

Choose a reason for hiding this comment

sarthakpati commented Mar 14, 2024

jakirkham left a comment

Choose a reason for hiding this comment

jakirkham commented Mar 19, 2024

sarthakpati left a comment • edited Loading

Choose a reason for hiding this comment

jakirkham commented Mar 20, 2024

sarthakpati commented Mar 22, 2024

sarthakpati left a comment •

edited

Loading