Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conda-build not yet compatible with LIEF 0.14 API changes #5227

Closed
2 tasks done
mbargull opened this issue Mar 11, 2024 · 0 comments · Fixed by #5228
Closed
2 tasks done

conda-build not yet compatible with LIEF 0.14 API changes #5227

mbargull opened this issue Mar 11, 2024 · 0 comments · Fixed by #5228
Labels
locked [bot] locked due to inactivity source::contributor created by a frequent contributor type::feature request for a new feature or capability
Milestone
24.3.x

Comments

@mbargull
Copy link
Member

Checklist

  • I added a descriptive title
  • I searched open reports and couldn't find a duplicate

What happened?

The have been some slight API changes in LIEF 0.14 which conda-build is not yet adjusted for:
https://github.com/lief-project/LIEF/blob/0.14.1/doc/sphinx/changelog.rst#L20

We have a LIEF 0.14 built on conda-forge via conda-forge/lief-feedstock#42 such that we can use conda-forge/label/lief_rc::py-lief=0.14.1 to try things out.
N.B.: py-lief=0.14.1 is the first version on conda-forge built for python=3.12 and as such a requirement for running conda-forge::conda-build with python=3.12.

Similar changes will be necessary in the future for LIEF >=0.15:
https://github.com/lief-project/LIEF/blob/1c9c8522b69b2505b15237734a7fbac2b48a592c/doc/sphinx/changelog.rst#L18

Conda Info

No response

Conda Config

No response

Conda list

No response

Additional Context

No response
@mbargull mbargull added type::bug describes erroneous operation, use severity::* to classify the type source::contributor created by a frequent contributor labels Mar 11, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in 🧭 Planning Mar 11, 2024
@mbargull mbargull mentioned this issue Mar 11, 2024
Merged
3 tasks
@mbargull mbargull added this to the 24.3.x milestone Mar 11, 2024
@mbargull mbargull added type::feature request for a new feature or capability and removed type::bug describes erroneous operation, use severity::* to classify the type labels Mar 11, 2024
@github-project-automation github-project-automation bot moved this from 🆕 New to 🏁 Done in 🧭 Planning Mar 11, 2024
mbargull added a commit to mbargull-feedstocks/conda-forge-repodata-patches-feedstock that referenced this issue Mar 25, 2024
@mbargull
Add py-lief<0.14 bound for conda-build<24.3.0
a267994 
ref:
- conda/conda-build#5227

Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
@mbargull mbargull mentioned this issue Mar 25, 2024
Merged
5 tasks
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Sep 9, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
locked [bot] locked due to inactivity source::contributor created by a frequent contributor type::feature request for a new feature or capability
Projects
🧭 Planning
Archived in project
Milestone
24.3.x
Development

Successfully merging a pull request may close this issue.

Add compatibility for LIEF=0.14 mbargull/conda-build
1 participant
@mbargull