Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Add note about non-git local source location needing to be within the feedstock directory tree #4660

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bskinn
Copy link

@bskinn bskinn commented Nov 30, 2022

Description

Based on recent personal experience, when building with an unpacked sdist that's not a git repository, in order for the source to be visible inside the docker container it appears to have to reside inside the feedstock directory tree.

That is, the build only worked when I unpacked the sdist in {repo}/recipe/{sdist unpack}. If I used an unpack location outside {repo}/recipe, the build would fail at the cp -a ... step.

NB: I didn't try unpacking it as {repo}/{sdist unpack}.

NB also, I didn't try to build using a git repo housed outside the repository.


I'm aiming this PR to clarify this requirement for the location of the source on the local filesystem.

If this is not actually supposed to be a requirement, then this PR should probably be a bug ticket, instead. Happy to put it wherever's best, and happy to do further testing if needed.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests? (N/A)
  • Add / update outdated documentation?

Based on recent personal experience
@conda-bot
Copy link
Contributor

We require contributors to sign our Contributor License Agreement and we don't have one on file for @bskinn.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature.

Copy link

github-actions bot commented Dec 1, 2023

Hi there, thank you for your contribution!

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this pull request to remain open please:

  1. Rebase and verify the changes still work
  2. Leave a comment with the current status

NOTE: If this pull request was closed prematurely, please leave a comment.

Thanks!

1 similar comment
Copy link

github-actions bot commented Dec 1, 2023

Hi there, thank you for your contribution!

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this pull request to remain open please:

  1. Rebase and verify the changes still work
  2. Leave a comment with the current status

NOTE: If this pull request was closed prematurely, please leave a comment.

Thanks!

@github-actions github-actions bot added stale [bot] marked as stale due to inactivity labels Dec 1, 2023
@bskinn
Copy link
Author

bskinn commented Dec 1, 2023

Weird, I completely missed the CLA comment, even though it clearly came into my email.

CLA signed.

@github-actions github-actions bot added stale::recovered [bot] recovered after being marked as stale and removed stale [bot] marked as stale due to inactivity labels Dec 2, 2023
@bskinn bskinn requested a review from a team as a code owner May 8, 2024 15:34
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label May 8, 2024
@beeankha beeankha added type::documentation request for improved documentation source::community catch-all for issues filed by community members labels May 9, 2024
@beeankha
Copy link
Member

beeankha commented May 9, 2024

@conda-bot check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA source::community catch-all for issues filed by community members stale::recovered [bot] recovered after being marked as stale type::documentation request for improved documentation
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

3 participants