-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Add note about non-git local source location needing to be within the feedstock directory tree #4660
base: main
Are you sure you want to change the base?
Conversation
Based on recent personal experience
We require contributors to sign our Contributor License Agreement and we don't have one on file for @bskinn. In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature. |
Hi there, thank you for your contribution! This pull request has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs. If you would like this pull request to remain open please:
NOTE: If this pull request was closed prematurely, please leave a comment. Thanks! |
1 similar comment
Hi there, thank you for your contribution! This pull request has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs. If you would like this pull request to remain open please:
NOTE: If this pull request was closed prematurely, please leave a comment. Thanks! |
Weird, I completely missed the CLA comment, even though it clearly came into my email. CLA signed. |
@conda-bot check |
Description
Based on recent personal experience, when building with an unpacked sdist that's not a git repository, in order for the source to be visible inside the docker container it appears to have to reside inside the feedstock directory tree.
That is, the build only worked when I unpacked the sdist in
{repo}/recipe/{sdist unpack}
. If I used an unpack location outside{repo}/recipe
, the build would fail at thecp -a ...
step.NB: I didn't try unpacking it as
{repo}/{sdist unpack}
.NB also, I didn't try to build using a git repo housed outside the repository.
I'm aiming this PR to clarify this requirement for the location of the source on the local filesystem.
If this is not actually supposed to be a requirement, then this PR should probably be a bug ticket, instead. Happy to put it wherever's best, and happy to do further testing if needed.
Checklist - did you ...
news
directory (using the template) for the next release's release notes?