Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: source.git_rev defaults to HEAD (meta.yaml) #5217

Merged
merged 2 commits into from
Mar 19, 2024
Merged

docs: source.git_rev defaults to HEAD (meta.yaml) #5217

merged 2 commits into from
Mar 19, 2024

Conversation

ytausch
Copy link
Contributor

@ytausch ytausch commented Mar 6, 2024

Description

According to the implementation, git_rev defaults to HEAD. This should be documented.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@ytausch ytausch requested a review from a team as a code owner March 6, 2024 10:27
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Mar 6, 2024
@ytausch ytausch mentioned this pull request Mar 6, 2024
Merged
@beeankha beeankha added type::documentation request for improved documentation source::community catch-all for issues filed by community members labels Mar 7, 2024
ryanskeith
ryanskeith approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@ryanskeith ryanskeith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@beeankha beeankha merged commit 3b1f4f1 into conda:main Mar 19, 2024
12 checks passed
@ytausch ytausch deleted the patch-3 branch March 22, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanskeith ryanskeith ryanskeith approved these changes

Assignees
No one assigned
Labels
cla-signed [bot] added once the contributor has signed the CLA source::community catch-all for issues filed by community members type::documentation request for improved documentation
Projects
🔎 Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ytausch @ryanskeith @conda-bot @beeankha