Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CodSpeed and add select lines benchmark #5233

Merged
merged 8 commits into from
Mar 15, 2024

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented Mar 13, 2024

Description

Enables CodSpeed benchmarks and adds a new test_select_lines_battery test.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Mar 13, 2024
@kenodegard kenodegard force-pushed the rendering-benchmark branch 5 times, most recently from 6f0bcdc to 70f56cb Compare March 14, 2024 18:41
@kenodegard kenodegard force-pushed the rendering-benchmark branch 2 times, most recently from e913dbf to d526c75 Compare March 14, 2024 19:08
Copy link

codspeed-hq bot commented Mar 14, 2024

CodSpeed Performance Report

Congrats! CodSpeed is installed 🎉

🆕 2 new benchmarks were detected.

You will start to see performance impacts in the reports once the benchmarks are run from your default branch.

Detected benchmarks

  • test_which_package_battery (5.1 s)
  • test_select_lines_battery (1.1 s)

@kenodegard kenodegard force-pushed the rendering-benchmark branch from bf1c5bc to 234a593 Compare March 14, 2024 20:21
@kenodegard kenodegard changed the title Enable CodSpeed and add rendering benchmark Enable CodSpeed and add select lines benchmark Mar 14, 2024
@kenodegard kenodegard marked this pull request as ready for review March 14, 2024 22:44
@kenodegard kenodegard requested a review from a team as a code owner March 14, 2024 22:44
@kenodegard kenodegard mentioned this pull request Mar 14, 2024
1 task
# create a dummy environment
(tmp_path / "conda-meta").mkdir()
(tmp_path / "conda-meta" / "history").touch()
(tmp_path / "lib").mkdir()

# dummy packages with files
removed = []
for _ in range(100):
for _ in range(10):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since CodSpeed is a profiler things naturally run slower, we change this value in order to get a more reasonable run time (30min+ vs seconds)

@kenodegard kenodegard merged commit 1a7e07c into conda:main Mar 15, 2024
28 checks passed
@kenodegard kenodegard deleted the rendering-benchmark branch March 15, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants