Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate noarch_python_build_age #5298

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

kenodegard
Copy link
Contributor

Description

Resolves #5297

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Apr 18, 2024
Copy link

codspeed-hq bot commented Apr 18, 2024

CodSpeed Performance Report

Merging #5298 will not alter performance

Comparing kenodegard:deprecate-noarch_python_build_age (1347bb4) with main (a6d53af)

Summary

✅ 3 untouched benchmarks

@kenodegard kenodegard marked this pull request as ready for review April 18, 2024 04:49
@kenodegard kenodegard requested a review from a team as a code owner April 18, 2024 04:49
@jakirkham
Copy link
Member

Had no idea this even existed 😳

Apparently neither did the docs:

Screenshot 2024-04-17 at 10 07 52 PM

+1 for deprecating (and eventually removing)

beeankha
beeankha previously approved these changes Apr 18, 2024
jezdez
jezdez previously approved these changes Apr 18, 2024
@jezdez
Copy link
Member

jezdez commented Apr 18, 2024

@kenodegard Whoops needs a rebase

@kenodegard kenodegard dismissed stale reviews from jezdez and beeankha via 76710c5 April 18, 2024 16:20
jezdez
jezdez previously approved these changes Apr 18, 2024
beeankha
beeankha previously approved these changes Apr 18, 2024
@jezdez jezdez enabled auto-merge (squash) April 18, 2024 16:49
@kenodegard kenodegard dismissed stale reviews from beeankha and jezdez via 1347bb4 April 18, 2024 22:49
@jezdez jezdez merged commit 5d8444b into conda:main Apr 19, 2024
28 checks passed
@kenodegard kenodegard deleted the deprecate-noarch_python_build_age branch April 19, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Deprecate noarch_python_build_age MetaData/Config setting
5 participants