-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: change definition of pkg_type variable in build function to solve KeyError: 'conda' #5560
Conversation
…e KeyError:'conda'
We require contributors to sign our Contributor License Agreement and we don't have one on file for @ypradat. In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#1072), and ping the bot to refresh the PR. |
@conda-bot check |
CodSpeed Performance ReportMerging #5560 will not alter performanceComparing Summary
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
@conda/builds-tools, any idea why the CI is not running here? edit: nvm, it was the new "merge experience" beta |
@conda/builds-tools - this is ready for review. |
Description
When trying to run
conda-build
on a simple perl package I wrote, I came across the erroralthough I specified
in the meta.yaml of the conda recipe of my package. I tried
as well but the same error occurred.
As a matter of fact, I don't quite understand how the current code can work. Looking at https://github.com/conda/conda/blob/main/conda/base/constants.py#L152-L153, we see clearly that acceptable keys for the
bundlers
dictionary are.conda
,.tar.bz2
, orwheel
, notconda
.I suggest to replace the definition of
pkg_type
in thebuild.py
function using the following piece of code fromrender.py
https://github.com/conda/conda-build/blob/main/conda_build/render.py#L73-L79.
Doing this replacement solved the KeyError issue for me.
Checklist - did you ...
Add a file to thenews
directory (using the template) for the next release's release notes?Add / update necessary tests?Add / update outdated documentation?