[Bug]: Adding a file or directory mount to a database, breaks defaul volume mount

[benosman]

Error Message and Logs

When adding file or directory mounts to a database service (tested with mariadb and mysql), the docker compose config is broken for the default volume mount (and additional ones).

This means that the db appears to lose data and is no longer persistent. Removing the mount restores the issue. It affects the config under services.<id>.volumes, not the root volumes.

Before adding mount:

services:
    zgwg4g0kck4s8cskokos84ss:
        ...
        volumes:
            - 'app-name-db:/var/lib/mysql'
volumes:
    app-name-db:
        name: app-name-db
        external: false

After adding mount:

services:
    zgwg4g0kck4s8cskokos84ss:
        ...
        volumes:
            - '/data/coolify/databases/zgwg4g0kck4s8cskokos84ss/root/.my.cnf:/root/.my.cnf'
volumes:
    app-name-db:
        name: app-name-db
        external: false

Steps to Reproduce

1. Create a mariadb database
2. Start database
3. Check docker-compose.yaml and volume should be correct.
4. Add file mount and save
5. Restart database
6. Check docker-compose.yaml and volume is likely incorrect.
7. Remove file mount and save
8. Restart database
9. Check docker-compose.yaml and volume should be correct.

Example Repository URL

No response

Coolify Version

v4.0.0-beta.390

Are you using Coolify Cloud?

No (self-hosted)

Operating System and Version (self-hosted)

AlmaLinux 9.5

Additional Information

The file mounts previously didn't work and was fixed after #4668

That might be a good start to see where the cause of this issue is.

[benosman]

I took a quick look at the code and it seems to affect all database drivers.

$docker_compose['services'][$container_name]['volumes'] is set but then overridden if $persistent_file_volumes is present. Instead it needs to create an empty array then push or to merge the two arrays.

        if (count($persistent_storages) > 0) {
            $docker_compose['services'][$container_name]['volumes'] = $persistent_storages;
        }
        if (count($persistent_file_volumes) > 0) {
            $docker_compose['services'][$container_name]['volumes'] = $persistent_file_volumes->map(function ($item) {
                return "$item->fs_path:$item->mount_path";
            })->toArray();
        }

[benosman]

@peaklabs-dev @andrasbacsai - I took a look at the pull request and I couldn't see any changes to the files I expected.

Could you point me to the commit with the fix?

[peaklabs-dev]

You cannot see the commit because it was only local, I committed it yesterday because of some testing and so on, but this is the commit: 5f357e3

[benosman]

thanks, I saw the release and the closing of this issue, at the same time so I went to check. I've got it working locally with an override, so I will wait for the next release before upgrading.

The commit looks like it should fix it, presumably it will be rolled out to all databases?

[peaklabs-dev]

yes other DBs are in testing locally.