From 8552ea5f6c2648ce734e78738f18d5377b0c7e8c Mon Sep 17 00:00:00 2001
From: ferran quer <raneq@posteo.net>
Date: Tue, 14 May 2019 19:32:07 +0200
Subject: [PATCH] Fix Odoo not installing when it should

I had this error https://github.com/ansible/ansible/issues/17500
register is executed on skipped tasks
---
 tasks/download.yml | 6 +++---
 tasks/main.yml     | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/tasks/download.yml b/tasks/download.yml
index 78e1cb2..4b4a135 100644
--- a/tasks/download.yml
+++ b/tasks/download.yml
@@ -15,7 +15,7 @@
       dest: "{{ odoo_role_odoo_download_path }}"
       owner: "{{ odoo_role_odoo_user }}"
       group: "{{ odoo_role_odoo_group }}"
-    register: odoo_role_desired_download
+    register: odoo_role_desired_tar_download
 
   - name: Clean older release packets
     vars:
@@ -37,7 +37,7 @@
       owner: "{{ odoo_role_odoo_user }}"
       group: "{{ odoo_role_odoo_group }}"
       extra_opts: [--strip-components=1]
-    when: odoo_role_desired_download.changed
+    when: odoo_role_desired_tar_download.changed
 
   when: odoo_role_download_strategy == "tar"
 
@@ -51,6 +51,6 @@
     version: "{{ odoo_role_odoo_git_ref }}"
     depth: 1
     force: yes
-  register: odoo_role_desired_download
+  register: odoo_role_desired_git_download
   when: odoo_role_download_strategy == "git"
 
diff --git a/tasks/main.yml b/tasks/main.yml
index 02d8822..5c8bef3 100644
--- a/tasks/main.yml
+++ b/tasks/main.yml
@@ -94,7 +94,7 @@
 - name: Install Odoo
   become_user: "{{ odoo_role_odoo_user }}"
   shell: "cd {{ odoo_role_odoo_path }} && {{ odoo_role_odoo_python_path }} setup.py install"
-  when: odoo_role_desired_download.changed
+  when: odoo_role_desired_tar_download.changed or odoo_role_desired_git_download.changed
 
 - name: Add Odoo config
   become: yes