Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse packet from events instead of manually constructing in endpoint.MsgSendPacket #7856

Open
gjermundgaraba opened this issue Jan 20, 2025 · 1 comment
Labels
feat: ibc-eureka good first issue Good for newcomers nice-to-have testing Testing package and unit/integration tests

Comments

@gjermundgaraba
Copy link
Contributor

Create a test utilities for Eureka packet parsing, similar to what we have here:

func ParsePacketsFromEvents(eventType string, events []abci.Event) ([]channeltypes.Packet, error) {

I would imagine we would need to rename and refactor a bit to make a clear distinction between the type of packet your expecting. So either parsing for an IBC Classic packet (the current functions) or an IBC Eureka packet.

Replace any places where we manually find the packet data or sequence today with the new test utilities method(s).

This functionality should target the feat/ibc-eureka branch (unless it has already been merged into main when this work is started).

Ref: cosmos/ibc#1165

@hungdinh82
Copy link
Contributor

@gjermundgaraba can I work on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: ibc-eureka good first issue Good for newcomers nice-to-have testing Testing package and unit/integration tests
Projects
Status: Backlog
Development

No branches or pull requests

2 participants