Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace get-libwasm-version.py script #7885

Open
gjermundgaraba opened this issue Jan 25, 2025 · 2 comments · May be fixed by #7889
Open

Replace get-libwasm-version.py script #7885

gjermundgaraba opened this issue Jan 25, 2025 · 2 comments · May be fixed by #7889
Assignees
Labels
good first issue Good for newcomers help wanted Issues for which we would appreciate help/support from the community nice-to-have

Comments

@gjermundgaraba
Copy link
Contributor

We currently use a python script to find the correct libwasm version to send to the 08-wasm Dockerfile.

This is overkill and requires installing python dependencies, which is not necessary for such as a simple operation.

The best solution would be for the dockerfile itself to find the correct libwasm version to download, but the next best solution is to replace the python script with a minimal bash script.

If we solve it in the dockerfile, remove the usage of the script in Makefile and the build-wasm-simd-image-from-tag.yml file. Otherwise, replace the invocation of scripts/get-libwasm-version.py with a minimal bash script that does not require any dependencies and just returns the version in the same way as the python script.

@gjermundgaraba gjermundgaraba added good first issue Good for newcomers help wanted Issues for which we would appreciate help/support from the community nice-to-have labels Jan 25, 2025
@ArtGinn
Copy link

ArtGinn commented Jan 27, 2025

Could I handle this @gjermundgaraba ?

@gjermundgaraba
Copy link
Contributor Author

Yes, that would be great @ArtGinn! I'll assign you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Issues for which we would appreciate help/support from the community nice-to-have
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants