-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Store quotes for limit orders #2078
Comments
I'd probably not make this an acceptance criteria. We could have already done that for all orders but we didn't so I think this is probably not super important. |
Should this also include that the driver has access to the fee (as this is likely where the default logic would be implemented) or is this a different task? |
Was cooking it in meantime, here it is: #2081 |
# Description Fixes #2078 # Changes <!-- List of detailed changes (how the change is accomplished) --> - [ ] Limit orders are no longer skipped when the quote is determined and stored into database. ## How to test Will observe the behavior on staging to make sure the quotes are stored.
Problem
Every time a limit order is created, a quote should be stored in database.
Additional context
Limit orders usually have a quote before being created, since UI asks for limit order quotes with
PriceQuality:Optimal
option, which means quote will be generated.Quote for Limit orders should be generated in the same way quotes are generated for market orders.
Acceptance criteria
Quotes for expired limit orders should be periodically removed from the database, for performance reasons.cc @MartinquaXD @fleupold wdyt?The text was updated successfully, but these errors were encountered: