Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Optionally enable quote verification #2310

Closed
MartinquaXD opened this issue Jan 22, 2024 · 0 comments · Fixed by #2327
Closed

chore: Optionally enable quote verification #2310

MartinquaXD opened this issue Jan 22, 2024 · 0 comments · Fixed by #2327
Labels
E:3.2 Verified Quotes See https://github.com/cowprotocol/pm/issues/15 for details

Comments

@MartinquaXD
Copy link
Contributor

Background

Currently the frontend has to tell us that the backend should verify a quote by passing priceQuality: "verified" in the /quote request.
To easily enforce in the future that all quotes have been verified we need to make sure the backend is able to decide on its own which quotes to verify.

Details

We should start by verifying all quotes where from is not 0 and the price_quality is not fast.
This should only happen conditionally based on a CLI flag in case we encounter any issues and have to quickly revert back to the status quo.

@MartinquaXD MartinquaXD added the E:3.2 Verified Quotes See https://github.com/cowprotocol/pm/issues/15 for details label Jan 22, 2024
MartinquaXD added a commit that referenced this issue Jan 25, 2024
# Description
Mostly moves code around and introduces trait for trade verification
which will later be used for unit tests.
Also adds the `verified` flag to quotes but at this point this flag is
not yet used for anything.

## How to test
Originally part of #2271 and
changes were manually tested there.
CI

Fixes: #2310
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:3.2 Verified Quotes See https://github.com/cowprotocol/pm/issues/15 for details
Projects
None yet
1 participant