Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: ETH-flow doesn't work with zero-signed fee change as order is classified as market #2356

Closed
harisang opened this issue Feb 2, 2024 · 1 comment · Fixed by #2368
Closed

bug: ETH-flow doesn't work with zero-signed fee change as order is classified as market #2356

harisang opened this issue Feb 2, 2024 · 1 comment · Fixed by #2368
Assignees
@sunce86
Labels
bug Something isn't working

Comments

@harisang
Copy link
Contributor

harisang commented Feb 2, 2024

We noticed that ETH-flow orders, while they are now submitted, created and executed with the CoW Swap zero-signed fee change, they always pay zero fee as they are classified as market and not limit orders.

See here for relevant discussion.
@harisang harisang added the bug Something isn't working label Feb 2, 2024
@fleupold
Copy link
Contributor

fleupold commented Feb 5, 2024 •
edited
Loading

@sunce86 can you tackle this issue this week as this is blocking the fee = 0 rollout?

@sunce86 sunce86 mentioned this issue Feb 6, 2024
Merged
2 tasks
sunce86 added a commit that referenced this issue Feb 6, 2024
@sunce86
Eth flow zero fee fix order class (#2368)
f945fdd 
# Description
Fixes #2356

# Changes
<!-- List of detailed changes (how the change is accomplished) -->

- [x] Order is `Market` if within market (by comparing to quote) AND if
signed `fee_amount` is > 0.
- [x] Adjust the `within_market` calculation to include fees (as already
discussed and fixed in other parts of the system)

## How to test
Adjusted existing tests. Added check for `executed_surplus_fee` for
signed zero fee ethflow order.
mfw78 pushed a commit that referenced this issue Feb 8, 2024
@sunce86 @mfw78
Eth flow zero fee fix order class (#2368)
85ec9f6 
# Description
Fixes #2356

# Changes
<!-- List of detailed changes (how the change is accomplished) -->

- [x] Order is `Market` if within market (by comparing to quote) AND if
signed `fee_amount` is > 0.
- [x] Adjust the `within_market` calculation to include fees (as already
discussed and fixed in other parts of the system)

## How to test
Adjusted existing tests. Added check for `executed_surplus_fee` for
signed zero fee ethflow order.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sunce86 sunce86

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Eth flow zero fee fix order class cowprotocol/services
3 participants
@fleupold @sunce86 @harisang