Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: OneInchSpotPrice estimator returning bogus native prices #2444

Closed
harisang opened this issue Feb 28, 2024 · 2 comments
Closed

bug: OneInchSpotPrice estimator returning bogus native prices #2444

harisang opened this issue Feb 28, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@harisang
Copy link
Contributor

We noticed an issue with at least one native price estimation, namely this token

0x48Fb253446873234F2fEBbF9BdeAA72d9d387f94

that was often reported by OneInchSpotPrice estimator to be worth ~79M ETH.

see logs here

There was a statistical test proposed at some point, but given it is not in place yet and given that verified quotes will probably not work for native price estimates, should we maybe consider adding some very loose limits on the native price estimates?

Something like "no token has a price more than, say 100 ETH?"

Not sure if this is a rare case, and I guess one would need to search in the logs (not sure how to do a '>' test in the logs though) to find out how often we have such cases.

@harisang harisang added the bug Something isn't working label Feb 28, 2024
Copy link

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

@github-actions github-actions bot added the Stale label Apr 29, 2024
@fleupold
Copy link
Contributor

Fixed by #2603

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants