chore: Combine verified quotes with TokenOwner logic #2446
Labels
E:3.2 Verified Quotes
See https://github.com/cowprotocol/pm/issues/15 for details
Comments
MartinquaXD
added
the
E:3.2 Verified Quotes
|
This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed. |
|
This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed. |
|
This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Background
Verified quotes currently expect the owner to have the require sell_token balance. This does not work when a user did not connect their wallet or generally tries to get a quote for way more than they have.
One possible option to still verify those cases would be to use the logic to find token owners to find an owner with a big enough balance for the trade and use that as the trader address instead.
It's not completely clear how useful this would actually be and if we even want to extend quote verification support for these corner cases so this should not be treated with high priority.
The text was updated successfully, but these errors were encountered: