Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persist Price Improvement protocol fee #2478

Closed
squadgazzz opened this issue Mar 5, 2024 · 0 comments · Fixed by #2470
Closed

Persist Price Improvement protocol fee #2478

squadgazzz opened this issue Mar 5, 2024 · 0 comments · Fixed by #2470
Assignees
@squadgazzz
Labels
E:4.2 Protocol Fee Implementation See https://github.com/cowprotocol/pm/issues/29 for details

Comments

@squadgazzz
Copy link
Contributor

#2287 pt5
@squadgazzz squadgazzz added E:4.2 Protocol Fee Implementation See https://github.com/cowprotocol/pm/issues/29 for details E:4.3 Protocol Fee PriceImprovement over Quote labels Mar 5, 2024
@squadgazzz squadgazzz mentioned this issue Mar 5, 2024
Closed
9 tasks
@squadgazzz squadgazzz self-assigned this Mar 5, 2024
@squadgazzz squadgazzz mentioned this issue Mar 5, 2024
Merged
3 tasks
squadgazzz added a commit that referenced this issue Mar 8, 2024
@squadgazzz
Store price improvement fee (#2470)
55d7a6d 
# Description
Fixes #2478

# Changes

- [ ] `max_volume_factor` column is renamed to
`surplus_max_volume_factor` in order to align with the naming convention
- [ ] Postgres roundtrip tests
- [ ] Readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@squadgazzz squadgazzz

Labels
E:4.2 Protocol Fee Implementation See https://github.com/cowprotocol/pm/issues/29 for details
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Store price improvement fee cowprotocol/services
1 participant
@squadgazzz