Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement rank by surplus for Volume based protocol fee #2491

Closed
sunce86 opened this issue Mar 7, 2024 · 0 comments · Fixed by #2497
Closed

feat: Implement rank by surplus for Volume based protocol fee #2491

sunce86 opened this issue Mar 7, 2024 · 0 comments · Fixed by #2497
Assignees
@sunce86

Comments

@sunce86
Copy link
Contributor

sunce86 commented Mar 7, 2024 •
edited
Loading

Problem

Implement CIP38 scoring for Volume based protocol fee.

Suggested solution

Volume should be calculated the same way the volume cap for surplus variant is calculated.

This is aligned with the solver rewards update: cowprotocol/solver-rewards#346
@sunce86 sunce86 mentioned this issue Mar 7, 2024
Merged
@sunce86 sunce86 self-assigned this Mar 8, 2024
sunce86 added a commit that referenced this issue Mar 15, 2024
@sunce86
Volume based protocol fee for scoring (#2497)
b8c8ebe 
# Description
Fixes #2491

Code moved into separate functions for reuse.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sunce86 sunce86

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Volume based protocol fee for scoring cowprotocol/services
1 participant
@sunce86