Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add driver tests for CIP38 scoring #2522

Closed
sunce86 opened this issue Mar 15, 2024 · 1 comment · Fixed by #2533
Closed

chore: Add driver tests for CIP38 scoring #2522

sunce86 opened this issue Mar 15, 2024 · 1 comment · Fixed by #2533
Assignees
@squadgazzz
Labels
E:4.2 Protocol Fee Implementation See https://github.com/cowprotocol/pm/issues/29 for details

Comments

@sunce86
Copy link
Contributor

sunce86 commented Mar 15, 2024

Background

Driver tests need to be added for CIP38 scoring. Test for all variants of protocol fee should be added:

  1. Surplus
  2. PriceImprovement
  3. Volume
@sunce86 sunce86 added E:4.2 Protocol Fee Implementation See https://github.com/cowprotocol/pm/issues/29 for details E:4.3 Protocol Fee PriceImprovement over Quote labels Mar 15, 2024
@sunce86 sunce86 mentioned this issue Mar 15, 2024
Merged
@fleupold
Copy link
Contributor

I think this could be part of the test suite in https://github.com/cowprotocol/services/blob/b8c8ebef41cb73c1f20c44791c72120dba560cbc/crates/driver/src/tests/cases/protocol_fees.rs

@squadgazzz squadgazzz mentioned this issue Mar 18, 2024
Closed
@squadgazzz squadgazzz self-assigned this Mar 18, 2024
@squadgazzz squadgazzz mentioned this issue Mar 18, 2024
Merged
3 tasks
squadgazzz added a commit that referenced this issue Mar 20, 2024
@squadgazzz
Rank by surplus tests (#2533)
fa1f8ea 
# Changes

- [x] Surplus
- [x] PriceImprovement
- [x] Volume

Scoring doesn't support `factor=1.0`, so some of the test values were
changed.

## Related Issues

Fixes #2522
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@squadgazzz squadgazzz

Labels
E:4.2 Protocol Fee Implementation See https://github.com/cowprotocol/pm/issues/29 for details
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rank by surplus tests cowprotocol/services
3 participants
@fleupold @sunce86 @squadgazzz