Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Market orders protocol fee #2548

Closed
squadgazzz opened this issue Mar 20, 2024 · 0 comments · Fixed by #2550
Closed

feat: Market orders protocol fee #2548

squadgazzz opened this issue Mar 20, 2024 · 0 comments · Fixed by #2550
Assignees
@squadgazzz
Labels
E:4.2 Protocol Fee Implementation See https://github.com/cowprotocol/pm/issues/29 for details

Comments

@squadgazzz
Copy link
Contributor

squadgazzz commented Mar 20, 2024 •
edited
Loading

Problem

More context: https://cowservices.slack.com/archives/C05N1FNP3MX/p1710852670240979

Suggested solution

Refactor the current policy fee config to split into 2 optional params: for market and limit orders.

Acceptance criteria

Another e2e test should probably needed to covert the new logic.
@squadgazzz squadgazzz added the E:4.2 Protocol Fee Implementation See https://github.com/cowprotocol/pm/issues/29 for details label Mar 20, 2024
@squadgazzz squadgazzz self-assigned this Mar 20, 2024
@squadgazzz squadgazzz changed the title feat: In-market orders protocol fee feat: market orders protocol fee Mar 20, 2024
@squadgazzz squadgazzz changed the title feat: market orders protocol fee feat: Market orders protocol fee Mar 20, 2024
@squadgazzz squadgazzz mentioned this issue Mar 20, 2024
Merged
squadgazzz added a commit that referenced this issue Mar 25, 2024
@squadgazzz
In/Out of market order protocol fee config (#2550)
27c3492 
# Description
Separate protocol fees config for in and out of market orders.

## How to test
`protocol_fee.rs` tests work with in-market orders. Removing
`in_market_fee_policy_kind` makes the tests fail.


## Related Issues
Fixes #2548
fleupold pushed a commit that referenced this issue Mar 26, 2024
@squadgazzz @fleupold
In/Out of market order protocol fee config (#2550)
ac6580a 
# Description
Separate protocol fees config for in and out of market orders.

## How to test
`protocol_fee.rs` tests work with in-market orders. Removing
`in_market_fee_policy_kind` makes the tests fail.


## Related Issues
Fixes #2548
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@squadgazzz squadgazzz

Labels
E:4.2 Protocol Fee Implementation See https://github.com/cowprotocol/pm/issues/29 for details
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

In/Out of market order protocol fee config cowprotocol/services
1 participant
@squadgazzz