Limit number of orders per merged solutions in driver #3314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstrug
reviewed
Mar 7, 2025
m-lord-renkse
approved these changes
Mar 7, 2025
|
@cowprotocol/solver do you guys think 3 is an appropriate choice here? |
mstrug
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3306
Driver tries to merge solutions received from solver API.
This PR introduces configuration parameter used to filter out all merged solutions that contain more than 3 orders. The purpose is to optimize solution building during volatility periods (in these periods solutions with lower number of orders are preferred as potentially easier to submit onchain - less likely to revert)
Changes