Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Limit the number of orders in merged solutions #3306

Open
sunce86 opened this issue Mar 4, 2025 · 2 comments · May be fixed by #3314
Open

feat: Limit the number of orders in merged solutions #3306

sunce86 opened this issue Mar 4, 2025 · 2 comments · May be fixed by #3314
Labels
oncall Issue/PR for consideration during oncall rotation

Comments

@sunce86
Copy link
Contributor

sunce86 commented Mar 4, 2025

Problem

Sometimes merged solutions are too big (contain too many orders) and are hard to settle onchain since the probability of state changing in between the solving and settling time is high. We need some additional way to lower the chances of revert.

Suggested solution

Add a configuration parameter to driver that limits the number of orders per merged solutions.
@sunce86 sunce86 added the oncall Issue/PR for consideration during oncall rotation label Mar 4, 2025
@fleupold
Copy link
Contributor

fleupold commented Mar 4, 2025

Basically we need to turn this constant into a config param.

@sunce86
Copy link
Contributor Author

sunce86 commented Mar 4, 2025

I think that constant limits the number of "mergings" to do, while we want to limit the number of orders per merged solution.

@sunce86 sunce86 linked a pull request Mar 6, 2025 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
oncall Issue/PR for consideration during oncall rotation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Limit number of orders per merged solutions in driver cowprotocol/services
2 participants
@fleupold @sunce86