Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classify Trade Simulation Errors #722

Closed
nlordell opened this issue Nov 4, 2022 · 1 comment
Closed

Classify Trade Simulation Errors #722

nlordell opened this issue Nov 4, 2022 · 1 comment
Labels
good first issue Good for newcomers

Comments

@nlordell
Copy link
Contributor

nlordell commented Nov 4, 2022

Currently, trade simulation errors are quantified as "Other" and lead to HTTP 500 errors if all estimators fail.

We should classify these errors separately and return a better error in these cases.

For example:

% curl -s http://localhost:8080/api/v1/quote -X POST -H 'content-type: application/json' --data '@-' <<JSON | jq
{
  "from": "0xf17afe5237d982868b8a97424dd79a4a50c36412",
  "sellToken": "0xdac17f958d2ee523a2206206994597c13d831ec7",
  "buyToken": "0x6b175474e89094c44da98b954eedeac495271d0f",
  "kind": "sell",
  "sellAmountBeforeFee": "1000000000"
}
JSON
{
  "errorType": "InternalServerError",
  "description": ""
}
@nlordell nlordell added the good first issue Good for newcomers label Nov 4, 2022
@fleupold
Copy link
Contributor

This issue will likely become irrelevant as part of the Verified Quotes initiative

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants