Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly define miter_limit values #168

Open
mikebmcl opened this issue May 24, 2018 · 0 comments
Open

properly define miter_limit values #168

mikebmcl opened this issue May 24, 2018 · 0 comments
Assignees
Labels

Comments

@mikebmcl
Copy link
Member

It needs a definition and right now doesn't have one. Essentially, greater than 0 degrees, not 180 degrees, and less than 360 degrees. Any value that would cause sin(val) to be 0.0f. Then change the interface to use degrees or radians or both (I'm pretty sure both was the LEWG consensus in Kona or Toronto for pi vs. theta so that will be relevant here I think).

@mikebmcl mikebmcl added the bug label May 24, 2018
@mikebmcl mikebmcl self-assigned this May 24, 2018
@mikebmcl mikebmcl added the P0 label May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant