From 976e4a4d70bae0d0919682353ac2f90421b7be4c Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Sat, 10 Dec 2022 06:15:52 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- script/enum-generator/EnumGenerator.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/script/enum-generator/EnumGenerator.py b/script/enum-generator/EnumGenerator.py index 26e5822c..215a6ccd 100644 --- a/script/enum-generator/EnumGenerator.py +++ b/script/enum-generator/EnumGenerator.py @@ -247,7 +247,26 @@ def main(): url = f'https://github.com/libvips/libvips/releases/download/v{version}/vips-{version}.tar.gz' tarball = wget.download(url) with tarfile.open(tarball) as tf: - tf.extractall() + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tf) with open(os.path.join(os.getcwd(), 'LICENSE'), 'r', encoding='utf-8') as infile: license_comment = infile.read()