Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add azurerm_private_dns_resolver_dns_forwarding_ruleset and azurerm_private_dns_resolver_forwarding_rule #936

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add azurerm_private_dns_resolver_dns_forwarding_ruleset and azurerm_private_dns_resolver_forwarding_rule #936

wants to merge 1 commit into from
+3,418 −78

Conversation

faizan-younus
Copy link
Contributor

Description of your changes

Added the resources azurerm_private_dns_resolver_dns_forwarding_ruleset and azurerm_private_dns_resolver_forwarding_rule which are already available in the terraform registry.

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

The code was tested locally with a KIND cluster and by running the following command. This will deploy both of the newly developed resources

kubectl apply -f examples/network/v1beta1/privatednsresolverforwardingrule.yaml

@faizan-younus
adding azurerm_private_dns_resolver_dns_forwarding_ruleset and `azu…
804bb70 
…rerm_private_dns_resolver_forwarding_rule`

Signed-off-by: faizan-younus <faizan@mobilabsolutions.com>
@faizan-younus
Copy link
Contributor Author

/test-examples="examples/network/v1beta1/privatednsresolverforwardingrule.yaml"

@faizan-younus
Copy link
Contributor Author

/test-examples="examples/network/v1beta1/privatednsresolverdnsforwardingruleset.yaml"

@faizan-younus
Copy link
Contributor Author

/test-examples="examples/network/v1beta1/privatednsresolverforwardingrule.yaml"

@faizan-younus
Copy link
Contributor Author

/test-examples="examples/network/v1beta1/privatednsresolverdnsforwardingruleset.yaml"

1 similar comment
@faizan-younus
Copy link
Contributor Author

/test-examples="examples/network/v1beta1/privatednsresolverdnsforwardingruleset.yaml"

@faizan-younus
Copy link
Contributor Author

Is this an issue with the test subscription while deleting the resources? When I test it at my end, I don't face any issues while deleting the resources. Also, I found out that the test was successful once and then keeps failing without any changes to the code. 🤔

@faizan-younus
Copy link
Contributor Author

/test-examples="examples/network/v1beta1/privatednsresolverdnsforwardingruleset.yaml"

@faizan-younus
Copy link
Contributor Author

/test-examples="examples/network/v1beta1/privatednsresolverforwardingrule.yaml"

@faizan-younus
Copy link
Contributor Author

/test-examples="examples/network/v1beta1/privatednsresolverdnsforwardingruleset.yaml"

1 similar comment
@faizan-younus
Copy link
Contributor Author

/test-examples="examples/network/v1beta1/privatednsresolverdnsforwardingruleset.yaml"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulucinar ulucinar Awaiting requested review from ulucinar ulucinar is a code owner

@sergenyalcin sergenyalcin Awaiting requested review from sergenyalcin sergenyalcin is a code owner

@turkenf turkenf Awaiting requested review from turkenf turkenf is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@faizan-younus