From 39a8c0ec80fa56c29fdb783ee2423fd5e3fa6dcf Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 19 Feb 2024 15:56:21 +0000 Subject: [PATCH 1/5] ci: bump super-linter/super-linter from 5 to 6 Bumps [super-linter/super-linter](https://github.com/super-linter/super-linter) from 5 to 6. - [Release notes](https://github.com/super-linter/super-linter/releases) - [Changelog](https://github.com/super-linter/super-linter/blob/main/CHANGELOG.md) - [Commits](https://github.com/super-linter/super-linter/compare/v5...v6) --- updated-dependencies: - dependency-name: super-linter/super-linter dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- .github/workflows/lint-extras.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/lint-extras.yaml b/.github/workflows/lint-extras.yaml index b44e89ed9..3d84b7a4d 100644 --- a/.github/workflows/lint-extras.yaml +++ b/.github/workflows/lint-extras.yaml @@ -19,7 +19,7 @@ jobs: uses: actions/checkout@v4 - name: Lint Code Base - uses: super-linter/super-linter/slim@v5 + uses: super-linter/super-linter/slim@v6 env: FILTER_REGEX_EXCLUDE: > (.*vendor/.*)|(.*tools/vendor/.*) From 7a492d79f5e86ed88f6610a431b3ac0d9027bec6 Mon Sep 17 00:00:00 2001 From: Niels de Vos Date: Tue, 20 Feb 2024 09:18:20 +0100 Subject: [PATCH 2/5] ci: pass GITHUB_TOKEN to super-linter Without the GITHUB_TOKEN in the environment, the super-linter workflow fails to set the CI status in PR's. Signed-off-by: Niels de Vos --- .github/workflows/lint-extras.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/lint-extras.yaml b/.github/workflows/lint-extras.yaml index 3d84b7a4d..d972bc40a 100644 --- a/.github/workflows/lint-extras.yaml +++ b/.github/workflows/lint-extras.yaml @@ -21,6 +21,7 @@ jobs: - name: Lint Code Base uses: super-linter/super-linter/slim@v6 env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} FILTER_REGEX_EXCLUDE: > (.*vendor/.*)|(.*tools/vendor/.*) VALIDATE_GO: false From 0c3874f00342ef2e698925f7183b947ed6ba916d Mon Sep 17 00:00:00 2001 From: Niels de Vos Date: Tue, 20 Feb 2024 09:24:27 +0100 Subject: [PATCH 3/5] ci: give super-linter permissions to write CI status in PR's Signed-off-by: Niels de Vos --- .github/workflows/lint-extras.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/lint-extras.yaml b/.github/workflows/lint-extras.yaml index d972bc40a..9d66542b7 100644 --- a/.github/workflows/lint-extras.yaml +++ b/.github/workflows/lint-extras.yaml @@ -9,6 +9,7 @@ on: permissions: contents: read + statuses: write jobs: test-lint: From 349a8cc30d115903a1b043a4ba9afdcc390dbe26 Mon Sep 17 00:00:00 2001 From: Niels de Vos Date: Tue, 20 Feb 2024 09:28:19 +0100 Subject: [PATCH 4/5] ci: checkout full history for super-linter workflow super-linter needs the full git history to get the list of files that changed across commits. Signed-off-by: Niels de Vos --- .github/workflows/lint-extras.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/lint-extras.yaml b/.github/workflows/lint-extras.yaml index 9d66542b7..c7cc5dd30 100644 --- a/.github/workflows/lint-extras.yaml +++ b/.github/workflows/lint-extras.yaml @@ -18,6 +18,8 @@ jobs: steps: - name: checkout source uses: actions/checkout@v4 + with: + fetch-depth: 0 - name: Lint Code Base uses: super-linter/super-linter/slim@v6 From a2c55046264c9aea2ae0149eddcd1a44b46a4e64 Mon Sep 17 00:00:00 2001 From: Niels de Vos Date: Tue, 20 Feb 2024 09:52:38 +0100 Subject: [PATCH 5/5] ci: disbled unused checks from super-linter checkov is a linter for infrastructire as code, which we do not use in this repository. It detects an error under the `vendor/` directory, which should be skipped either way (filtering not working for this checker?). There is no need to run the checked for Go modules. We have other CI jobs that validate the Go modules already. Because parts of Kubernetes are vendored (which is large), the Go module checker times out. Signed-off-by: Niels de Vos --- .github/workflows/lint-extras.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/lint-extras.yaml b/.github/workflows/lint-extras.yaml index c7cc5dd30..100a7b6b0 100644 --- a/.github/workflows/lint-extras.yaml +++ b/.github/workflows/lint-extras.yaml @@ -27,7 +27,9 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} FILTER_REGEX_EXCLUDE: > (.*vendor/.*)|(.*tools/vendor/.*) + VALIDATE_CHECKOV: false VALIDATE_GO: false + VALIDATE_GO_MODULES: false VALIDATE_JSCPD: false VALIDATE_KUBERNETES_KUBECONFORM: false VALIDATE_PROTOBUF: false