Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch constructors to initializers to support Chapel 1.19 #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Switch constructors to initializers to support Chapel 1.19 #9

wants to merge 2 commits into from

Conversation

ben-albrecht
Copy link
Contributor

  • Switched constructors to initializers
  • Bumped chplVersion to 1.19.0
  • Bumped PATCH version such that version is now 0.1.1

Closes #8

ben-albrecht added 2 commits April 12, 2019 10:03
Update constructors to use initializers
67637ac
Update Chapel compatibility version bump PATCH version
ffbae49 
According to SemVer (https://github.com/semver/semver) , a patch to support a
dependency change (considering Chapel a dependency in this case) is
still only a PATCH update, as long as the public interface is unchanged.
So bumping to 0.1.1 rather than 0.2.0.
@ben-albrecht
Copy link
Contributor Author

@ct-clmsn - Would you mind reviewing? I've confirmed that all MatrixMarket tests in the Chapel repo pass with these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Chapel 1.19
1 participant
@ben-albrecht