Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge points not calculated properly for bundled beziers when an unbundled edge exists between the same source and target #3322

Open
7 tasks
maxkfranz opened this issue Jan 15, 2025 · 1 comment
Assignees
Labels
bug A bug in the code of Cytoscape.js
Milestone

Comments

@maxkfranz
Copy link
Member

maxkfranz commented Jan 15, 2025

Before you post

A request for help or a request for a how-to should be directed to Phind.

If your issue pertains to an extension, your issue should be filed in that extension's repository -- not here.

Environment info

  • Cytoscape.js version : 3.31.0
  • Browser/Node.js & version : Chrome 131, Safari 18.2

Current (buggy) behaviour

What does the bug do?

When a set of bundled bezier edges has a parallel edge that is unbundled, the set of bundled edges is not calculated properly. When dragging the target node, for example, the bundled beziers flash between two sets of points.

Desired behaviour

What do you expect Cytoscape.js to do instead?

Bundled beziers should not be affected by unbundled edges.

Minimum steps to reproduce

What do you need to do to reproduce the issue?

See the updated debug demo page, which contains an unbundled edge between nodes d and e, in addition to the bundled beziers.

Commit: f34682c

Expected:

Screenshot 2025-01-15 at 15 50 14

Actual:

Screenshot 2025-01-15 at 15 50 03

For reviewers

Reviewers should ensure that the following tasks are carried out for incorporated issues:

  • Ensure that the reporter has included a reproducible demo. They can easily fork this JSBin demo: http://jsbin.com/fiqugiq
  • The issue has been associated with a corresponding milestone.
  • The commits have been incorporated into the corresponding branches. Bug-fix patches go on
    • master,
    • unstable, and
    • the previous feature release branch (e.g. 1.1.x if the current release is 1.2).
  • The issue has been labelled as a bug, if necessary.
@maxkfranz maxkfranz added the bug A bug in the code of Cytoscape.js label Jan 15, 2025
@maxkfranz maxkfranz added this to the 3.31.1 milestone Jan 15, 2025
@maxkfranz maxkfranz self-assigned this Jan 15, 2025
maxkfranz added a commit that referenced this issue Jan 15, 2025
- It should show what the library does by default as much as possible.
- Add edge for: Edge points not calculated properly for bundled beziers when an unbundled edge exists between the same source and target #3322

Ref: Edge points not calculated properly for bundled beziers when an unbundled edge exists between the same source and target #3322
maxkfranz added a commit that referenced this issue Jan 15, 2025
…ints

Ref: Edge points not calculated properly for bundled beziers when an unbundled edge exists between the same source and target #3322
maxkfranz added a commit that referenced this issue Feb 3, 2025
…rallel-edges-w-unbundled

Put unbundled edges in a separate key in the control point table

Ref: Edge points not calculated properly for bundled beziers when an unbundled edge exists between the same source and target #3322
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug in the code of Cytoscape.js
Projects
None yet
Development

No branches or pull requests

1 participant