-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect assumption about FCM endpoint #14
Comments
Hi, thanks for reporting the issue. |
Yes, only, this will effectively reverse #13 so I am curious why @splagemann fixed this in the first place... |
I'm pretty sure that I had issues without an auth key. But I can check that again and I'm happy to have that removed. |
I had issues with an auth key :-) |
This code asserts that an auth key (GCM sender ID) is required when a push subscription is sent from FCM. However, this is not true because FCM fully implements VAPID, as can be read here: "With VAPID you no longer need to sign up for an account with GCM".
My suggestion therefore is to remove this function clause altogether, as well as this part.
The text was updated successfully, but these errors were encountered: