Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scoped comments not accepted #16

Open
drahnr opened this issue Aug 30, 2022 · 4 comments
Open

Scoped comments not accepted #16

drahnr opened this issue Aug 30, 2022 · 4 comments

Comments

@drahnr
Copy link
Contributor

drahnr commented Aug 30, 2022

Create a few scoped comments, got this:

Error: Error during POST: Status code: 422 Unprocessable Entity, Body: {"message":"Unprocessable Entity","errors":["Pull request review thread start line must precede the end line."],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-review-for-a-pull-request"}

It would be awesome if the scoped comments would be displayed and checked for consistency with possible error messages on the line numbers.

@danobi
Copy link
Owner

danobi commented Aug 31, 2022

Error checking would be good. Do you have a reproducer I can test with?

@drahnr
Copy link
Contributor Author

drahnr commented Aug 31, 2022

I do, just need to vet for any leaks, could I sent you this on another channel after I vetted it?

@danobi
Copy link
Owner

danobi commented Aug 31, 2022

Sure. Try my email in the git log.

@keevan
Copy link

keevan commented Sep 10, 2022

I have an example of this happening.

In particular, it deleting line 13 (thus removing the "scope block" format) will allow this to submit, but including the empty line will not.

6.prr.txt

prr get danobi/prr-test-repo/6
# edit it to match the above
prr submit danobi/prr-test-repo/6

Related but side question, how do you mix and match scoped and inline comments? In this linked example (also based on this file) it doesn't apply an inline comment and usage is a bit ambigious.

danobi/prr-test-repo#6 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants