Make the tests honest

Author: dantswain

test/controllers/page_controller_test.exs

@@ -3,6 +3,6 @@ defmodule Beanie.PageControllerTest do
 
   test "GET /", %{conn: conn} do
     conn = get conn, "/"
-    assert html_response(conn, 200) =~ "Welcome to Phoenix!"
+    assert html_response(conn, 200) =~ "Beanie"
   end
 end

test/controllers/repository_controller_test.exs

@@ -3,31 +3,17 @@ defmodule Beanie.RepositoryControllerTest do
 
   alias Beanie.Repository
   @valid_attrs %{name: "some content"}
-  @invalid_attrs %{}
+  @invalid_attrs %{name: nil}
+
+  @valid_repository %Repository{name: "name"}
 
   test "lists all entries on index", %{conn: conn} do
     conn = get conn, repository_path(conn, :index)
     assert html_response(conn, 200) =~ "Listing repositories"
   end
 
-  test "renders form for new resources", %{conn: conn} do
-    conn = get conn, repository_path(conn, :new)
-    assert html_response(conn, 200) =~ "New repository"
-  end
-
-  test "creates resource and redirects when data is valid", %{conn: conn} do
-    conn = post conn, repository_path(conn, :create), repository: @valid_attrs
-    assert redirected_to(conn) == repository_path(conn, :index)
-    assert Repo.get_by(Repository, @valid_attrs)
-  end
-
-  test "does not create resource and renders errors when data is invalid", %{conn: conn} do
-    conn = post conn, repository_path(conn, :create), repository: @invalid_attrs
-    assert html_response(conn, 200) =~ "New repository"
-  end
-
   test "shows chosen resource", %{conn: conn} do
-    repository = Repo.insert! %Repository{}
+    repository = Repo.insert! @valid_repository
     conn = get conn, repository_path(conn, :show, repository)
     assert html_response(conn, 200) =~ "Show repository"
   end
@@ -39,28 +25,21 @@ defmodule Beanie.RepositoryControllerTest do
   end
 
   test "renders form for editing chosen resource", %{conn: conn} do
-    repository = Repo.insert! %Repository{}
+    repository = Repo.insert! @valid_repository
     conn = get conn, repository_path(conn, :edit, repository)
     assert html_response(conn, 200) =~ "Edit repository"
   end
 
   test "updates chosen resource and redirects when data is valid", %{conn: conn} do
-    repository = Repo.insert! %Repository{}
+    repository = Repo.insert! @valid_repository
     conn = put conn, repository_path(conn, :update, repository), repository: @valid_attrs
     assert redirected_to(conn) == repository_path(conn, :show, repository)
     assert Repo.get_by(Repository, @valid_attrs)
   end
 
   test "does not update chosen resource and renders errors when data is invalid", %{conn: conn} do
-    repository = Repo.insert! %Repository{}
+    repository = Repo.insert! @valid_repository
     conn = put conn, repository_path(conn, :update, repository), repository: @invalid_attrs
     assert html_response(conn, 200) =~ "Edit repository"
   end
-
-  test "deletes chosen resource", %{conn: conn} do
-    repository = Repo.insert! %Repository{}
-    conn = delete conn, repository_path(conn, :delete, repository)
-    assert redirected_to(conn) == repository_path(conn, :index)
-    refute Repo.get(Repository, repository.id)
-  end
 end

web/controllers/repository_controller.ex

@@ -19,19 +19,6 @@ defmodule Beanie.RepositoryController do
     end
   end
 
-  def create(conn, %{"repository" => repository_params}) do
-    changeset = Repository.changeset(%Repository{}, repository_params)
-
-    case Repo.insert(changeset) do
-      {:ok, _repository} ->
-        conn
-        |> put_flash(:info, "Repository created successfully.")
-        |> redirect(to: repository_path(conn, :index))
-      {:error, changeset} ->
-        render(conn, "new.html", changeset: changeset)
-    end
-  end
-
   def show(conn, params = %{"id" => id}) do
     repository = fetch_repository(id, params["update"])
     render(conn, "show.html", repository: repository)
@@ -57,18 +44,6 @@ defmodule Beanie.RepositoryController do
     end
   end
 
-  def delete(conn, %{"id" => id}) do
-    repository = Repo.get!(Repository, id)
-
-    # Here we use delete! (with a bang) because we expect
-    # it to always work (and if it does not, it will raise).
-    Repo.delete!(repository)
-
-    conn
-    |> put_flash(:info, "Repository deleted successfully.")
-    |> redirect(to: repository_path(conn, :index))
-  end
-
   defp repository_list("true") do
     %{"repositories" => from_docker} = Beanie.RegistryAPI.catalog(Beanie.registry)
     Beanie.Repository.Query.update_list(from_docker)