Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dark theme #2625

Open
feinstein opened this issue Sep 7, 2020 · 2 comments
Open

Add dark theme #2625

feinstein opened this issue Sep 7, 2020 · 2 comments
Assignees
@parlough
Labels
e3-weeks Complete in < 4 weeks of normal, not dedicated, work from.user Issue raised by user infra.design Relates to the design of docs.Dart.dev infra.structure Relates to the tools that create dart.dev p2-medium Necessary but not urgent concern. Resolve when possible.

Comments

@feinstein
Copy link

feinstein commented Sep 7, 2020 •
edited
Loading

Could we have a dark theme for the website? It's a lot better to read at night, something like https://firebase.flutter.dev/docs/overview.

image
@kwalrath kwalrath added infra.design Relates to the design of docs.Dart.dev e2-days Can complete in < 5 days of normal, not dedicated, work e3-weeks Complete in < 4 weeks of normal, not dedicated, work infra.structure Relates to the tools that create dart.dev p3-low Valid but not urgent concern. Resolve when possible. Encourage upvote to surface. from.user Issue raised by user labels Sep 9, 2020
@kwalrath
Copy link
Contributor

kwalrath commented Sep 9, 2020

That's pretty cool! We're on different infrastructure, so I suspect it'd be a lot of work (and thus unlikely to get done), but you never know.

@parlough parlough mentioned this issue Oct 3, 2022
Closed
@parlough parlough added p2-medium Necessary but not urgent concern. Resolve when possible. and removed p3-low Valid but not urgent concern. Resolve when possible. Encourage upvote to surface. e2-days Can complete in < 5 days of normal, not dedicated, work labels Jul 30, 2023
@parlough parlough mentioned this issue Jul 30, 2023
Closed
@baturax
Copy link

baturax commented Dec 28, 2024

this would really be good. it hurts my eyes at night

@parlough parlough mentioned this issue Jan 21, 2025
Merged
MaryaBelanger pushed a commit that referenced this issue Jan 21, 2025
@parlough
New layout implementation and sidenav design (#6344)
736baa3 
- Updates the sidenav static generation logic to match `flutter/website`
for improved build performance and consistency. Also removes the need
for specifying `match-page-url-exactly` on directory index pages.
- This changes the 11ty related `filters.ts` and `eleventyComputed.js`
files. These changes have already been reviewed and been in use by
`flutter/website` for a while.
- Redesigns the sidenav for improved accessibility and reducing
dependence on Bootstrap.
- Reimplements the site layout in preparation for Bootstrap removal and
improving scrolling.
- Removes a bunch of now unneeded logic and styles, further supporting
the later removal of Bootstrap.

Fixes #5791
Fixes #5789
Contributes to #4164
Contributes to #3849
Prepares for #2625
@parlough parlough mentioned this issue Feb 18, 2025
Merged
parlough added a commit that referenced this issue Feb 18, 2025
@parlough
Update alert styles to be more accessible and match Flutter docs (#6430)
918606e 
Also contributes to #2625 as
these styles will be easier to support and more accessible in a dark
mode.
@parlough parlough self-assigned this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parlough parlough

Labels
e3-weeks Complete in < 4 weeks of normal, not dedicated, work from.user Issue raised by user infra.design Relates to the design of docs.Dart.dev infra.structure Relates to the tools that create dart.dev p2-medium Necessary but not urgent concern. Resolve when possible.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kwalrath @feinstein @parlough @antfitch @baturax