Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blanket /guides redirect #6385

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Fix blanket /guides redirect #6385

merged 1 commit into from
Feb 3, 2025

Conversation

parlough
Copy link
Member

@parlough parlough commented Feb 3, 2025

Fixes #6384 by moving the blanket redirect to a fallback redirect

@dart-github-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit d0a4f68):

https://dart-dev--pr6385-fix-6384-oitu0l4j.web.app

Copy link
Contributor

@MaryaBelanger MaryaBelanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is only because search takes you from staging to the live site, but when I search "environment" from your staging link, it takes me to dart.dev/docs (live site)

I'm just going to approve this because I'm assuming this can't really be tested from staging, but let me know if I can test it some other way!

@parlough
Copy link
Member Author

parlough commented Feb 3, 2025

I'm not sure if this is only because search takes you from staging to the live site, but when I search "environment" from your staging link, it takes me to dart.dev/docs (live site)

The current embedded search experience is essentially embedding Google Search, so it will only take you to the live indexed version.

@parlough parlough merged commit 347e239 into main Feb 3, 2025
10 checks passed
@parlough parlough deleted the fix/6384 branch February 3, 2025 19:30
@dkbast
Copy link
Contributor

dkbast commented Feb 3, 2025

👍 can confirm that this works - thanks for the quick response!

@parlough
Copy link
Member Author

parlough commented Feb 3, 2025

@dkbast Thanks for noticing and calling this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing redirects for (all?) guides
4 participants