Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rendering of printedVariable blows up if @index is a variable reference #57

Open
davemckain opened this issue Jan 5, 2015 · 1 comment
Open

Rendering of printedVariable blows up if @index is a variable reference #57

davemckain opened this issue Jan 5, 2015 · 1 comment
Labels
bug

Comments

@davemckain
Copy link
Owner

The rendering XSLT for printedVariable is currently expecting @index to be an integer, rather than integerOrVariableRef, and is consequently blowing up if the attribute is a variable reference.
@davemckain davemckain added the bug label Jan 5, 2015
@davemckain davemckain mentioned this issue Jan 5, 2015
Open
@davemckain
Copy link
Owner Author

This one is going to require some effort to fix. The current rendering of printedVariable does all of the variable de-referencing within the XSLT. Handling integerOrVariableRef is non-trivial (as one can see from the corresponding implementation of this within the Java classes). I think it might be better to add an XML filter to the rendering pipeline the computes the final value for each printedVariable (using the existing Java logic) and substitutes the result into the XML before it gets passed to the rendering XSLT. That would simplify the amount of work the XSLT has to do here.

davemckain added a commit that referenced this issue Jan 5, 2016
@davemckain
Issue #57: Added guard to prevent blow-ups
654ae85 
I have added a guard condition to prevent rendering from blowing up if
@index is a variable reference. Rendering will now continue, but a
message will be shown instead of the de-referenced value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davemckain