Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start schema registry using a dedicated function, not in the constructor #36

Closed
davideicardi opened this issue Jan 9, 2021 · 0 comments · Fixed by #43
Closed

Start schema registry using a dedicated function, not in the constructor #36

davideicardi opened this issue Jan 9, 2021 · 0 comments · Fixed by #43
Labels
enhancement New feature or request

Comments

@davideicardi
Copy link
Owner

Consider also the producer
@davideicardi davideicardi changed the title Eval if we should start consuming schemas on demand instead of in the constructor of the schema registry Start schema registry using a dedicated function, not in the constructor Feb 13, 2021
@davideicardi davideicardi added the enhancement New feature or request label Mar 22, 2021
@davideicardi davideicardi mentioned this issue Mar 26, 2021
Merged
davideicardi added a commit that referenced this issue Mar 26, 2021
@davideicardi
Feature/start schemaregistry ondemand (#43)
7645dcb 
- Rename `GenericSerde` to `KaaSerde` (to support case classes serialization/deserialization)
- Add `KaaGenericSerde` to support serialization/deserialization of `GenericRecord`.
- Add `KaaSerde` and `KaaGenericSerde` implicits (close #42)
- `KaaSchemaRegistry.start` should be called to connect to Kafka and start consuming records (instead of automatically connect in constructor). This is to have a more controller life cycle, for example creating the instance but do not connect yet (useful for DI). And now you can `close` and `start` multiple times reusing the same instance. (close #36)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/start schemaregistry ondemand davideicardi/kaa
1 participant
@davideicardi