Feature/start schemaregistry ondemand #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GenericSerdetoKaaSerde(to support case classes serialization/deserialization)KaaGenericSerdeto support serialization/deserialization ofGenericRecord.KaaSerdeandKaaGenericSerdeimplicits (close Add implicit serde #42)KaaSchemaRegistry.startshould be called to connect to Kafka and start consuming records (instead of automatically connect in constructor). This is to have a more controller life cycle, for example creating the instance but do not connect yet (useful for DI). And now you cancloseandstartmultiple times reusing the same instance. (close Start schema registry using a dedicated function, not in the constructor #36)