Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to compile on the aarch64 architecture. #30

Open
RainSnowIceRain opened this issue Mar 1, 2025 · 3 comments
Open

Failed to compile on the aarch64 architecture. #30

RainSnowIceRain opened this issue Mar 1, 2025 · 3 comments

Comments

@RainSnowIceRain
Copy link

Why was the static assertion static_assert(x86_64, "The platform must be 64bit!"); added at line 104 in the file src/common/utils/Status.h? Does this imply that the code is not supported for deployment on machines with the aarch64 architecture?

@dylangerdaly
Copy link

C'monnnnnn, pls support aarch64.

@SF-Zhou
Copy link
Collaborator

SF-Zhou commented Mar 2, 2025

In the Status struct, we utilize the high 16 bits of 64-bit pointers to store status codes. This feature is available on x86_64 architectures and most aarch64 architectures (like folly/PackedSyncPtr). While we plan to remove restrictions for aarch64 architectures, our production environment currently only has x86_64 machines, making it impossible to test compilation and runtime behavior on aarch64. We welcome any feedback!

@Nugine
Copy link
Contributor

Nugine commented Mar 2, 2025

GitHub Actions provides aarch64 linux runners for free. It's possible to test compilation on an aarch64 runner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants