FETCH_KEY_PAIR / FETCH_UNIQUE / FETCH_GROUP fetch modes

[bfinlay]

In writing framework benchmark, one of the test cases required data that would have been more conveniently fetched using the FETCH_KEY_PAIR mode. I worked around it by using array_column.

It would be more convenient to either specify the fetch mode as an optional parameter to select or have additional methods (like selectColumn).

public static function fortunes(App $app) {
        $fortunes = Controller::getDb()->select(
            'SELECT * FROM Fortune'
        );
        $fortunes = array_column($fortunes, 'message', 'id');
        $fortunes[0] = 'Additional fortune added at request time.';
        asort($fortunes);
        echo $app->view('fortunes.html.twig', ['fortunes' => $fortunes]);
    }

benchmark code: https://github.com/bfinlay/FrameworkBenchmarks/blob/delight.im/frameworks/PHP/delight.im/app/Controller.php

[ocram]

Excellent point, thank you!

While we only use \PDO::FETCH_ASSOC internally so far, we definitely want to support the following additional “fetch styles”:

\PDO::FETCH_OBJ
    => selectAsObjects + selectRowAsObject
\PDO::FETCH_NUM
    => selectNumbered + selectRowNumbered
\PDO::FETCH_CLASS
    => selectIntoClass + selectRowIntoClass
    or
    => selectAsInstances + selectRowAsInstance
\PDO::FETCH_CLASS | PDO::FETCH_PROPS_LATE
    => selectIntoConstructedClass + selectRowIntoConstructedClass
    or
    => selectAsConstructedInstances + selectRowAsConstructedInstance
\PDO::FETCH_KEY_PAIR
    => selectAsPairs + selectRowAsPair
\PDO::FETCH_UNIQUE
    => selectUnique + selectRowUnique
\PDO::FETCH_GROUP
    => selectGrouped + selectRowGrouped

Yes, some of these are a bit verbose. But you have IDEs with autocomplete everywhere, and we currently can’t think of any solution other than these separate methods that we like as much.

What do you think?

[bfinlay]

I agree that the IDE autocomplete addresses verbosity concerns. These would work great!