Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
samuelFain authored Jan 15, 2025
1 parent 67cedaa commit dd55754
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,23 +1,23 @@
# Changelog
## 1.33.5 (2025-01-14)
### Feature
* Modified the pre-commit tests collections flow to collect all tests files in the same directory as a changed script for improved robustness. [#4761](https://github.com/demisto/demisto-sdk/pull/4761)
* Modified the ***pre-commit*** command tests collections flow to collect all tests files in the same directory as a changed script for improved robustness. [#4761](https://github.com/demisto/demisto-sdk/pull/4761)
* Reduced commands startup time. [#4752](https://github.com/demisto/demisto-sdk/pull/4752)
* RN111 will now fail when "Updated the docker image..." was added when it should not have been. Added a fix method to this validation. [#4741](https://github.com/demisto/demisto-sdk/pull/4741)
* Added IF109 to the new validation format. The validation Checks whether an incident or indicator field has a valid required field value. [#4753](https://github.com/demisto/demisto-sdk/pull/4753)
* Added IF117 to the new validation format. The validation Checks whether an incident or indicator field aliases have a valid marketplaces field value. [#4753](https://github.com/demisto/demisto-sdk/pull/4753)
* *RN111* will now fail when unnecessarily updating a docker image. [#4741](https://github.com/demisto/demisto-sdk/pull/4741)
* Added *IF109* to the new validation format. Checks whether an incident or indicator field has a valid required field value. [#4753](https://github.com/demisto/demisto-sdk/pull/4753)
* Added *IF117* to the new validation format. Checks whether an incident or indicator field aliases have a valid marketplaces field value. [#4753](https://github.com/demisto/demisto-sdk/pull/4753)

### Fix
* Resolved an issue with handling special characters in the update-release-notes --text parameter. [#4751](https://github.com/demisto/demisto-sdk/pull/4751)
* Fixed an issue in ***update-release-notes*** command will fail when handling special characters in the **--text** argument. [#4751](https://github.com/demisto/demisto-sdk/pull/4751)
* Fixed an issue where in some cases, parsing playbook related files would fail due to naming discrepancy. [#4758](https://github.com/demisto/demisto-sdk/pull/4758)
* Fixed an issue where the update-release-notes command would delete the version from the pack metadata when using the -u flag with an invalid value. [#4765](https://github.com/demisto/demisto-sdk/pull/4765)
* Fixed an issue where the ***update-release-notes*** command would delete the version from the pack metadata when using the **-u** flag with an invalid value. [#4765](https://github.com/demisto/demisto-sdk/pull/4765)
* Locked poetry v1.8.5 version. [#4756](https://github.com/demisto/demisto-sdk/pull/4756)
* Fixed an issue where the **ST110** validation failed when adding the marketplaces key to the CaseLayout content item. [#4763](https://github.com/demisto/demisto-sdk/pull/4763)
* Update Ruff Hook to use the argument output-format [#4767](https://github.com/demisto/demisto-sdk/pull/4767)
* Fixed an issue where the *ST110* validation failed when adding the marketplaces key to the CaseLayout content item. [#4763](https://github.com/demisto/demisto-sdk/pull/4763)
* Updated ***pre-commit*** command **Ruff** Hook to use the *output-format* argument. [#4767](https://github.com/demisto/demisto-sdk/pull/4767)

### Internal
* Added the validation `IF118` to the new validation format. The validation checks if an alias of an incident field has it's own alias. [#4748](https://github.com/demisto/demisto-sdk/pull/4748)
* Added the validation `PB121` to the new validation format. The validation checks if the inputs of a playbook that are intended to be fetched from the context are in the correct format. [#4702](https://github.com/demisto/demisto-sdk/pull/4702)
* Added *IF118* to the new validation format. Checks if an alias of an incident field has it's own alias. [#4748](https://github.com/demisto/demisto-sdk/pull/4748)
* Added *PB121* to the new validation format. Checks if the inputs of a playbook that are intended to be fetched from the context are in the correct format. [#4702](https://github.com/demisto/demisto-sdk/pull/4702)


## 1.33.4 (2025-01-06)
Expand Down

0 comments on commit dd55754

Please sign in to comment.