From 0737790ea1fcf1e9a52b763f74bd7f8d4bf06b73 Mon Sep 17 00:00:00 2001
From: Eli Luberoff <eli@desmos.com>
Date: Mon, 3 Feb 2025 14:04:08 -0500
Subject: [PATCH] respond to code review

---
 docs/Config.md    |  2 +-
 src/controller.ts | 11 ++++-------
 2 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/docs/Config.md b/docs/Config.md
index cac50a9d6..9a61397d6 100644
--- a/docs/Config.md
+++ b/docs/Config.md
@@ -129,7 +129,7 @@ For example, [Desmos](https://www.desmos.com/calculator) substitutes `<textarea
 Sets a tabindex on the field, following the standard spec. When tabindex is -1,
 the math field is not part of the page's tab order. Despite that, the math field can still be focused when selected by a mouse.
 
-Static math fields default to `tabindex: -1`, Editable math fields default to `tabindex: 1`.
+Static math fields default to `tabindex: -1`, Editable math fields default to `tabindex: 0`.
 
 ## disableAutoSubstitutionInSubscripts
 
diff --git a/src/controller.ts b/src/controller.ts
index 757618deb..a45fddb0e 100644
--- a/src/controller.ts
+++ b/src/controller.ts
@@ -96,20 +96,17 @@ class ControllerBase {
     return this;
   }
   setAriaLabel(ariaLabel: string) {
-    var oldAriaLabel = this.getAriaLabel();
-    if (ariaLabel === oldAriaLabel) return this;
-    if (ariaLabel && typeof ariaLabel === 'string' && ariaLabel !== '') {
-      this.ariaLabel = ariaLabel;
-    } else if (this.editable) {
+    const oldAriaLabel = this.getAriaLabel();
+    if (!ariaLabel && this.editable) {
       this.ariaLabel = 'Math Input';
     } else {
-      this.ariaLabel = '';
+      this.ariaLabel = ariaLabel;
     }
     // If this field doesn't have focus, update its computed mathspeak value.
     // We check for focus because updating the aria-label attribute of a focused element will cause most screen readers to announce the new value (in our case, label along with the expression's mathspeak).
     // If the field does have focus at the time, it will be updated once a blur event occurs.
     // Unless we stop using fake text inputs and emulating screen reader behavior, this is going to remain a problem.
-    if (this.ariaLabel !== oldAriaLabel && !this.containerHasFocus()) {
+    if (ariaLabel !== oldAriaLabel && !this.containerHasFocus()) {
       this.updateMathspeak();
     }
     return this;